make zdtype abstract methods raise notimplementederror#3251
Merged
dstansby merged 7 commits intozarr-developers:mainfrom Jul 16, 2025
Merged
make zdtype abstract methods raise notimplementederror#3251dstansby merged 7 commits intozarr-developers:mainfrom
dstansby merged 7 commits intozarr-developers:mainfrom
Conversation
github-actions
bot
added
the
needs release notes
github-actions
bot
removed
the
needs release notes
Contributor
Author
|
partially addresses #3247 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3251 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 78 78
Lines 8690 8696 +6
=======================================
+ Hits 8223 8229 +6
Misses 467 467
🚀 New features to boost your workflow:
|
TomNicholas
reviewed
Jul 15, 2025
dstansby
suggested changes
Jul 16, 2025
Contributor
dstansby
left a comment
dstansby
left a comment
There was a problem hiding this comment.
I think you missed a couple of methods, specifically _from_json_v2 and _from_json_v3
Contributor
Author
good catch, I added these in f7978d9 |
dstansby
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Description of PR]
TODO:
docs/user-guide/*.rstchanges/