allow roundtripping the BytesCodec#3417
Open
keewis wants to merge 7 commits intozarr-developers:mainfrom
Open
Conversation
github-actions
bot
added
the
needs release notes
github-actions
bot
removed
the
needs release notes
Contributor
Author
|
looks like some tests actually relied on this behavior, i.e. choosing the default endian if none was specified for multi-byte dtypes (even though this technically violates the spec). Since this might be potentially user facing (I'm not certain, but at least What we could do is start a deprecation cycle by checking for this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3416
Basically, we're changing the default for
endianwhen constructingBytesCodecusingfrom_dict.(I also renamed
test_endian.pytotest_bytes.pyas mentioned in #3416 (comment))TODO:
Add docstrings and API docs for any new/modified user-facing classes and functionsNew/modified features documented indocs/user-guide/*.rstchanges/