Skip to content

TEST: fix group selection for delete #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcherian merged 5 commits into from
Feb 21, 2026
Merged

TEST: fix group selection for delete #3707

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
484a62f
TEST: fix group selection for delete
ianhi Feb 12, 2026
0137a74
even more safety
ianhi Feb 12, 2026
20ab882
dont need to remove root group
ianhi Feb 20, 2026
14d0ab1
Merge branch 'main' into fix/stateful-delete-group-precondition
ianhi Feb 20, 2026
0aa8059
Merge branch 'main' into fix/stateful-delete-group-precondition
dcherian Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/zarr/testing/stateful.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,13 +340,13 @@ def delete_array_using_del(self, data: DataObject) -> None:
self.all_arrays.remove(array_path)

@precondition(lambda self: self.store.supports_deletes)
@precondition(lambda self: len(self.all_groups) >= 2) # fixme don't delete root
@precondition(lambda self: bool(self.all_groups - {"", "/"}))
Comment thread
ianhi marked this conversation as resolved.
Outdated
@rule(data=st.data())
def delete_group_using_del(self, data: DataObject) -> None:
# ensure that we don't include the root group in the list of member names that we try
# to delete
member_names = tuple(filter(lambda v: "/" in v, sorted(self.all_groups)))
group_path = data.draw(st.sampled_from(member_names), label="Group deletion target")
group_path = data.draw(
st.sampled_from(sorted(self.all_groups - {"", "/"})),
label="Group deletion target",
)
prefix, group_name = split_prefix_name(group_path)
note(f"Deleting group '{group_path=!r}', {prefix=!r}, {group_name=!r} using delete")
members = zarr.open_group(store=self.model, path=group_path).members(max_depth=None)
Expand All @@ -359,9 +359,7 @@ def delete_group_using_del(self, data: DataObject) -> None:
group = zarr.open_group(store=store, path=prefix)
group[group_name] # check that it exists
del group[group_name]
if group_path != "/":
# The root group is always present
self.all_groups.remove(group_path)
self.all_groups.remove(group_path)

# # --------------- assertions -----------------
# def check_group_arrays(self, group):
Expand Down