Skip to content

fix: BaseFloat._check_scalar rejects invalid string values (#3586) #3762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-v-b merged 2 commits into from
Mar 11, 2026
Merged

fix: BaseFloat._check_scalar rejects invalid string values (#3586) #3762

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cc034d
fix: BaseFloat._check_scalar rejects invalid string values (#3586)
Mar 11, 2026
c7ea02b
style: fix ruff formatting and TRY300 in _check_scalar
Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/zarr/core/dtype/npy/float.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,15 @@ def _check_scalar(self, data: object) -> TypeGuard[FloatLike]:
TypeGuard[FloatLike]
True if the input is a valid scalar value, False otherwise.
"""
if isinstance(data, str):
# Only accept strings that are valid float representations (e.g. "NaN", "inf").
# Plain strings that cannot be converted should return False so that cast_scalar
# raises TypeError rather than a confusing ValueError.
try:
self.to_native_dtype().type(data)
return True
except (ValueError, OverflowError):
return False
return isinstance(data, FloatLike)

def _cast_scalar_unchecked(self, data: FloatLike) -> TFloatScalar_co:
Expand Down
6 changes: 3 additions & 3 deletions tests/test_dtype/test_npy/test_float.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class TestFloat16(_BaseTestFloat):
(Float16(), -1.0, np.float16(-1.0)),
(Float16(), "NaN", np.float16("NaN")),
)
invalid_scalar_params = ((Float16(), {"set!"}),)
invalid_scalar_params = ((Float16(), {"set!"}), (Float16(), "not_a_float"),)
hex_string_params = (("0x7fc0", np.nan), ("0x7fc1", np.nan), ("0x3c00", 1.0))
item_size_params = (Float16(),)

Expand Down Expand Up @@ -113,7 +113,7 @@ class TestFloat32(_BaseTestFloat):
(Float32(), -1.0, np.float32(-1.0)),
(Float32(), "NaN", np.float32("NaN")),
)
invalid_scalar_params = ((Float32(), {"set!"}),)
invalid_scalar_params = ((Float32(), {"set!"}), (Float32(), "not_a_float"),)
hex_string_params = (("0x7fc00000", np.nan), ("0x7fc00001", np.nan), ("0x3f800000", 1.0))
item_size_params = (Float32(),)

Expand Down Expand Up @@ -160,7 +160,7 @@ class TestFloat64(_BaseTestFloat):
(Float64(), -1.0, np.float64(-1.0)),
(Float64(), "NaN", np.float64("NaN")),
)
invalid_scalar_params = ((Float64(), {"set!"}),)
invalid_scalar_params = ((Float64(), {"set!"}), (Float64(), "not_a_float"),)
hex_string_params = (
("0x7ff8000000000000", np.nan),
("0x7ff8000000000001", np.nan),
Expand Down
Loading