chore: no warning if array.target_shard_size_bytes is set with shards="auto"#3883
Open
ilan-gold wants to merge 4 commits intozarr-developers:mainfrom
Open
chore: no warning if array.target_shard_size_bytes is set with shards="auto"#3883ilan-gold wants to merge 4 commits intozarr-developers:mainfrom
array.target_shard_size_bytes is set with shards="auto"#3883ilan-gold wants to merge 4 commits intozarr-developers:mainfrom
Conversation
github-actions
bot
added
the
needs release notes
github-actions
bot
removed
the
needs release notes
3 tasks
ilan-gold
changed the title
array.target_shard_size_bytes is set with shards="auto"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3883 +/- ##
=======================================
Coverage 92.98% 92.98%
=======================================
Files 87 87
Lines 11246 11247 +1
=======================================
+ Hits 10457 10458 +1
Misses 789 789
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started a zulip discussion here and I feel like the following PR is reasonable. Using sharding simply to make file systems more performant while viewing the subchunks as the real "units" seems to be a nice use-case and if you opt-in to "auto" with a target size, maybe you shouldn't get a warning?
We could in theory also document the strategy of "pack chunks in equally along all dimensions" but is there really any appetite to change that? That stands in contrast to the current "auto" behavior (without a target size) of 2 chunks per dimension in the shard, which does seems like the sort of thing that could change.
TODO:
docs/user-guide/*.mdchanges/