[do not merge] benchmarks + tests for phased codecpipeline#3891
Open
d-v-b wants to merge 18 commits intozarr-developers:mainfrom
Open
[do not merge] benchmarks + tests for phased codecpipeline#3891d-v-b wants to merge 18 commits intozarr-developers:mainfrom
d-v-b wants to merge 18 commits intozarr-developers:mainfrom
Conversation
`PreparedWrite` models a set of per-chunk changes that would be applied to a stored chunk. `SupportsChunkPacking` is a protocol for array -> bytes codecs that can use `PreparedWrite` objects to update an existing chunk.
…into perf/prepared-write-v2
…into perf/prepared-write-v2
…into perf/prepared-write-v2
… into perf/prepared-write-v2-bench
…rf/prepared-write-v2
… into perf/prepared-write-v2-bench
8db7399 to
e82da5b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3891 +/- ##
==========================================
- Coverage 92.98% 92.09% -0.90%
==========================================
Files 87 87
Lines 11246 11809 +563
==========================================
+ Hits 10457 10875 +418
- Misses 789 934 +145
🚀 New features to boost your workflow:
|
… into perf/prepared-write-v2-bench
… into perf/prepared-write-v2-bench
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should not be merged. It contains changes necessary to make the codec pipeline developed in #3885 the default, which allows us to run our full test suite + benchmarks against that codec pipeline class.