Skip to content

[do not merge] benchmarks + tests for phased codecpipeline#3891

Open
d-v-b wants to merge 18 commits intozarr-developers:mainfrom
d-v-b:perf/prepared-write-v2-bench
Open

[do not merge] benchmarks + tests for phased codecpipeline#3891
d-v-b wants to merge 18 commits intozarr-developers:mainfrom
d-v-b:perf/prepared-write-v2-bench

Conversation

@d-v-b
Copy link
Copy Markdown
Contributor

@d-v-b d-v-b commented Apr 9, 2026

This PR should not be merged. It contains changes necessary to make the codec pipeline developed in #3885 the default, which allows us to run our full test suite + benchmarks against that codec pipeline class.

d-v-b added 9 commits April 7, 2026 10:38
`PreparedWrite` models a set of per-chunk changes that would be applied to a stored chunk. `SupportsChunkPacking`
is a protocol for array -> bytes codecs that can use `PreparedWrite` objects to update an existing chunk.
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Apr 9, 2026
@d-v-b d-v-b added the benchmark Code will be benchmarked in a CI job. label Apr 9, 2026
@d-v-b d-v-b force-pushed the perf/prepared-write-v2-bench branch from 8db7399 to e82da5b Compare April 9, 2026 14:16
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 86.62207% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.09%. Comparing base (9681cf9) to head (8330cde).

Files with missing lines Patch % Lines
src/zarr/core/codec_pipeline.py 86.18% 63 Missing ⚠️
src/zarr/codecs/numcodecs/_codecs.py 66.66% 8 Missing ⚠️
src/zarr/codecs/sharding.py 92.30% 7 Missing ⚠️
src/zarr/codecs/_v2.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3891      +/-   ##
==========================================
- Coverage   92.98%   92.09%   -0.90%     
==========================================
  Files          87       87              
  Lines       11246    11809     +563     
==========================================
+ Hits        10457    10875     +418     
- Misses        789      934     +145     
Files with missing lines Coverage Δ
src/zarr/abc/codec.py 98.86% <100.00%> (+0.09%) ⬆️
src/zarr/core/array.py 97.65% <100.00%> (+0.01%) ⬆️
src/zarr/core/config.py 100.00% <ø> (ø)
src/zarr/codecs/_v2.py 90.19% <80.00%> (-3.43%) ⬇️
src/zarr/codecs/sharding.py 75.42% <92.30%> (-13.99%) ⬇️
src/zarr/codecs/numcodecs/_codecs.py 93.18% <66.66%> (-3.21%) ⬇️
src/zarr/core/codec_pipeline.py 87.62% <86.18%> (-6.57%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Code will be benchmarked in a CI job. needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant