Skip to content

chore: prefix registry variable names with a single underscore#3894

Merged
d-v-b merged 2 commits intozarr-developers:mainfrom
d-v-b:chore/dont-dunder
Apr 9, 2026
Merged

chore: prefix registry variable names with a single underscore#3894
d-v-b merged 2 commits intozarr-developers:mainfrom
d-v-b:chore/dont-dunder

Conversation

@d-v-b
Copy link
Copy Markdown
Contributor

@d-v-b d-v-b commented Apr 9, 2026

closes #3893

@d-v-b d-v-b requested a review from maxrjones April 9, 2026 10:48
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.98%. Comparing base (bd23984) to head (5890548).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3894   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files          87       87           
  Lines       11246    11246           
=======================================
  Hits        10457    10457           
  Misses        789      789           
Files with missing lines Coverage Δ
src/zarr/registry.py 89.47% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b
Copy link
Copy Markdown
Contributor Author

d-v-b commented Apr 9, 2026

ci failure (docs) and the coverage issues are spurious.

@d-v-b d-v-b merged commit 85dfbcb into zarr-developers:main Apr 9, 2026
27 of 28 checks passed
@maxrjones
Copy link
Copy Markdown
Member

ci failure (docs) and the coverage issues are spurious.

fyi docs failures are addressed by #3887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

don't use __ as a prefix for variables in registry.py

2 participants