Skip to content

fix: defer to fsspec for memory url scheme#3944

Merged
d-v-b merged 4 commits into
zarr-developers:mainfrom
d-v-b:fix/fsspec-overrides-memory-store
May 5, 2026
Merged

fix: defer to fsspec for memory url scheme#3944
d-v-b merged 4 commits into
zarr-developers:mainfrom
d-v-b:fix/fsspec-overrides-memory-store

Conversation

@d-v-b
Copy link
Copy Markdown
Contributor

@d-v-b d-v-b commented May 4, 2026

Only associate the "memory" scheme with ManagedMemoryStore when fsspec is not installed.

closes #3939

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 4, 2026
@github-actions github-actions Bot removed the needs release notes Automatically applied to PRs which haven't added release notes label May 4, 2026
@d-v-b d-v-b mentioned this pull request May 4, 2026
6 tasks
@d-v-b d-v-b requested review from maxrjones May 4, 2026 22:52
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.23%. Comparing base (021662c) to head (adfb05d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3944   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          87       87           
  Lines       11695    11695           
=======================================
  Hits        10904    10904           
  Misses        791      791           
Files with missing lines Coverage Δ
src/zarr/storage/_common.py 86.47% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b
Copy link
Copy Markdown
Contributor Author

d-v-b commented May 5, 2026

I added a test, when it passes I will merge this.

@d-v-b d-v-b enabled auto-merge (squash) May 5, 2026 04:10
@d-v-b d-v-b merged commit 37ae37b into zarr-developers:main May 5, 2026
28 checks passed
@d-v-b d-v-b deleted the fix/fsspec-overrides-memory-store branch May 5, 2026 04:36
@maxrjones
Copy link
Copy Markdown
Member

Thanks for fixing this, @d-v-b!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memory:// URL scheme no longer routes to fsspec, breaking interop with MemoryFileSystem

2 participants