Skip to content

test: add property tests for block and mask indexing#4054

Merged
maxrjones merged 3 commits into
zarr-developers:mainfrom
maxrjones:property-tests-block-mask-indexing
Jun 9, 2026
Merged

test: add property tests for block and mask indexing#4054
maxrjones merged 3 commits into
zarr-developers:mainfrom
maxrjones:property-tests-block-mask-indexing

Conversation

@maxrjones

Copy link
Copy Markdown
Member

This is a complement to #4001 to improve property tests for block selection and mask selection.

These tests are left unmarked, so they run in the default test suite and the dedicated hypothesis.yaml CI job, matching the existing indexing hypothesis tests. I could make them as slow_hypothesis if we want to save ~10s on everyday test runs.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.53%. Comparing base (b9d3964) to head (c206ed2).

Files with missing lines Patch % Lines
src/zarr/testing/strategies.py 86.95% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4054   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          88       88           
  Lines       11894    11917   +23     
=======================================
+ Hits        11125    11147   +22     
- Misses        769      770    +1     
Files with missing lines Coverage Δ
src/zarr/testing/strategies.py 94.73% <86.95%> (+0.07%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/zarr/testing/strategies.py Outdated

@dcherian dcherian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supporting rectilinear shouldn't be too hard to add? LGTM otherwise

@maxrjones

Copy link
Copy Markdown
Member Author

Supporting rectilinear shouldn't be too hard to add? LGTM otherwise

good idea, I'll note that as a follow up

@maxrjones maxrjones merged commit 96a62b5 into zarr-developers:main Jun 9, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants