test: add property tests for block and mask indexing#4054
Merged
maxrjones merged 3 commits intoJun 9, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4054 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 88 88
Lines 11894 11917 +23
=======================================
+ Hits 11125 11147 +22
- Misses 769 770 +1
🚀 New features to boost your workflow:
|
dcherian
reviewed
Jun 8, 2026
dcherian
approved these changes
Jun 9, 2026
dcherian
left a comment
Contributor
There was a problem hiding this comment.
Supporting rectilinear shouldn't be too hard to add? LGTM otherwise
Member
Author
good idea, I'll note that as a follow up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a complement to #4001 to improve property tests for block selection and mask selection.
These tests are left unmarked, so they run in the default test suite and the dedicated
hypothesis.yamlCI job, matching the existing indexing hypothesis tests. I could make them asslow_hypothesisif we want to save ~10s on everyday test runs.TODO:
docs/user-guide/*.mdchanges/