Add bfloat16 data type#257
Open
jbms wants to merge 1 commit into
Open
Conversation
Member
|
I would have assumed that this would be a separate spec under data-types, since it's optional. I can see that this is a lot of boilerplate for a rather simple data type, but on the other hand not all future optional data types should be in the core spec IMO. So I'd draw the line at optional data-types. |
Member
|
Thanks for sending the PR, @jbms and reviewing @jstriebel. @jbms - do you think |
5 tasks
Member
|
For this PR (independent of any other discussion) I would suggest we follow the same outline as described for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.