Skip to content

Commit c0cf4ae

Browse files
committed
feat: update default values
1 parent f0f95ac commit c0cf4ae

3 files changed

Lines changed: 25 additions & 12 deletions

File tree

Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ type: application
1515
# This is the chart version. This version number should be incremented each time you make changes
1616
# to the chart and its templates, including the app version.
1717
# Versions are expected to follow Semantic Versioning (https://semver.org/)
18-
version: 0.3.2
18+
version: 0.3.3
1919

2020
# This is the version number of the application being deployed. This version number should be
2121
# incremented each time you make changes to the application. Versions are not expected to

README.md

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,42 @@
11
# Helmchart for generic python application
22

3-
[![Packahe Helm Chart](https://github.com/zcsadmin/ml-pyhchart-helmchart/actions/workflows/helm-package.yml/badge.svg)](https://github.com/zcsadmin/ml-pyhchart-helmchart/actions/workflows/helm-package.yml)
3+
[![Package Helm Chart](https://github.com/zcsadmin/ml-pyhchart-helmchart/actions/workflows/helm-package.yml/badge.svg)](https://github.com/zcsadmin/ml-pyhchart-helmchart/actions/workflows/helm-package.yml)
44

55
[![Push Helm Chart to Artifact Registry](https://github.com/zcsadmin/ml-pyhchart-helmchart/actions/workflows/helm-push.yml/badge.svg)](https://github.com/zcsadmin/ml-pyhchart-helmchart/actions/workflows/helm-push.yml)
66

7-
87
## Changelog
98

9+
### 0.3.3
10+
11+
Set rolling update strategy, pod disruption budget and replicaCount to 1.
12+
1013
### 0.3.0
11-
Set rolling update strategy, pod distruption budget and replicaCount to 3 for production environments.
12-
For Sandbox and Development environments we must set replicaCount in values.yaml to 1 and pdb.enabled to false.
1314

14-
### 0.2.2
15+
Set rolling update strategy, pod disruption budget and replicaCount to 3 for production environments.
16+
For Sandbox and Development environments we must set replicaCount in values.yaml to 1 and pdb.enabled to false.
17+
18+
### 0.2.2
19+
1520
Set container name for deployment.
1621

1722
### 0.2.1
23+
1824
Enhance secrets support.
1925

2026
### 0.2.0
27+
2128
Add support for secret values.
2229

2330
### 0.1.0
31+
2432
Initial chart release.
2533

2634
## Artifact Repository
2735

2836
`oci://europe-west1-docker.pkg.dev/ai-accounting-405809/ml-helm-charts/pyhchart`
2937

3038
List docker images from cli:
39+
3140
```bash
3241
gcloud artifacts docker images list europe-west1-docker.pkg.dev/ai-accounting-405809/ml-helm-charts
3342
```
@@ -37,10 +46,11 @@ gcloud artifacts docker images list europe-west1-docker.pkg.dev/ai-accounting-40
3746
You need to download the chart locally and `appVersion` value in `Chart.yaml` file.
3847
Also, you need a `values-app.yaml` file with the specific values for your application.
3948
Then, you can install the application with the following command:
49+
4050
```bash
4151
helm install YOUR_APP -f values-app.yaml .
4252
```
4353

4454
## Useful links
4555

46-
- [Artifact repository](https://console.cloud.google.com/artifacts/docker/ai-accounting-405809/europe-west1/ml-helm-charts/pyhchart?project=ai-accounting-405809)
56+
- [Artifact repository](https://console.cloud.google.com/artifacts/docker/ai-accounting-405809/europe-west1/ml-helm-charts/pyhchart?project=ai-accounting-405809)

values.yaml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,19 @@
22
# This is a YAML-formatted file.
33
# Declare variables to be passed into your templates.
44

5-
replicaCount: 3
5+
replicaCount: 1
66

7+
# https://www.baeldung.com/ops/deployment-rollout-kubernetes
8+
# https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
79
rollingUpdate:
8-
maxUnavailable: 1
9-
maxSurge: 1
10+
maxUnavailable: 25%
11+
maxSurge: 25%
1012

11-
# for
13+
# https://www.baeldung.com/ops/kubernetes-pod-disruption-budget
14+
# https://kubernetes.io/docs/tasks/run-application/configure-pdb/
1215
pdb:
1316
enabled: true
14-
minAvailable: 2
17+
minAvailable: 1
1518

1619
image:
1720
repository:

0 commit comments

Comments
 (0)