fix: detect duplicate template functionality

Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>

Author: zebbern

scripts/__tests__/template-library-live-audit-utils.test.ts

@@ -626,6 +626,22 @@ describe('template library live audit helpers', () => {
           recommendation: 'keep',
           rationale: 'Live execution completed and produced at least one artifact.',
         },
+        {
+          templateId: 'tpl-functional-copy',
+          templateName: 'Package Advisory Scanner',
+          seedFile: 'package-advisory-scanner.json',
+          category: 'cve-research',
+          components: ['sentris.osv.query'],
+          requiredSecrets: [],
+          runtimeInputs: [{ id: 'packageName' }],
+          classification: 'live-run',
+          createOk: true,
+          runAttempted: true,
+          terminalStatus: 'COMPLETED',
+          artifactsCount: 1,
+          recommendation: 'keep',
+          rationale: 'Live execution completed and produced at least one artifact.',
+        },
         {
           templateId: 'tpl-static',
           templateName: 'Static Demo Template',
@@ -648,6 +664,9 @@ describe('template library live audit helpers', () => {
     expect(markdown).toContain(
       '- Duplicate name: npm-dependency-cve-hunt.json, npm-dependency-cve-hunt-copy.json',
     );
+    expect(markdown).toContain(
+      '- Duplicate functionality: npm-dependency-cve-hunt.json, npm-dependency-cve-hunt-copy.json, package-advisory-scanner.json',
+    );
     expect(markdown).toContain(
       '- Low-value/static candidate: static-demo-template.json has no runtime inputs or required secrets.',
     );
@@ -702,10 +721,27 @@ describe('template library live audit helpers', () => {
         recommendation: 'review',
         rationale: 'Static demonstration workflow.',
       },
+      {
+        templateId: 'tpl-functional-copy',
+        templateName: 'Package Advisory Scanner',
+        seedFile: 'package-advisory-scanner.json',
+        category: 'cve-research',
+        components: ['sentris.osv.query'],
+        requiredSecrets: [],
+        runtimeInputs: [{ id: 'packageName' }],
+        classification: 'live-run',
+        createOk: true,
+        runAttempted: true,
+        terminalStatus: 'COMPLETED',
+        artifactsCount: 1,
+        recommendation: 'keep',
+        rationale: 'Live execution completed and produced at least one artifact.',
+      },
     ]);
 
     expect(failures).toEqual([
       'Duplicate template name: npm-dependency-cve-hunt.json, npm-dependency-cve-hunt-copy.json',
+      'Duplicate template functionality: npm-dependency-cve-hunt.json, npm-dependency-cve-hunt-copy.json, package-advisory-scanner.json',
       'Low-value/static template: static-demo-template.json has no runtime inputs or required secrets.',
     ]);
   });
@@ -759,15 +795,35 @@ describe('template library live audit helpers', () => {
         recommendation: 'review',
         rationale: 'Static demonstration workflow.',
       },
+      {
+        templateId: 'tpl-functional-copy',
+        templateName: 'Package Advisory Scanner',
+        seedFile: 'package-advisory-scanner.json',
+        category: 'cve-research',
+        components: ['sentris.osv.query'],
+        requiredSecrets: [],
+        runtimeInputs: [{ id: 'packageName' }],
+        classification: 'live-run',
+        createOk: true,
+        runAttempted: true,
+        terminalStatus: 'COMPLETED',
+        artifactsCount: 1,
+        recommendation: 'keep',
+        rationale: 'Live execution completed and produced at least one artifact.',
+      },
     ]);
 
     expect(report).toContain('# Template Catalog Quality Check');
     expect(report).toContain('Duplicate names: 1');
+    expect(report).toContain('Duplicate functionality: 1');
     expect(report).toContain('Low-value/static candidates: 1');
     expect(report).toContain('## Catalog Quality Failures');
     expect(report).toContain(
       '- Duplicate template name: npm-dependency-cve-hunt.json, npm-dependency-cve-hunt-copy.json',
     );
+    expect(report).toContain(
+      '- Duplicate template functionality: npm-dependency-cve-hunt.json, npm-dependency-cve-hunt-copy.json, package-advisory-scanner.json',
+    );
     expect(report).toContain(
       '- Low-value/static template: static-demo-template.json has no runtime inputs or required secrets.',
     );

scripts/template-library-live-audit-utils.ts

@@ -156,13 +156,19 @@ export interface TemplateCatalogDuplicateNameGroup {
   labels: string[];
 }
 
+export interface TemplateCatalogDuplicateFunctionalityGroup {
+  key: string;
+  labels: string[];
+}
+
 export interface TemplateCatalogLowValueCandidate {
   label: string;
   reason: string;
 }
 
 export interface TemplateCatalogQualitySummary {
   duplicateNames: TemplateCatalogDuplicateNameGroup[];
+  duplicateFunctionalities: TemplateCatalogDuplicateFunctionalityGroup[];
   lowValueCandidates: TemplateCatalogLowValueCandidate[];
 }
 
@@ -642,14 +648,60 @@ function getTemplateCatalogLabel(result: TemplateAuditMarkdownResult): string {
   return result.seedFile ?? result.templateName;
 }
 
+function getRuntimeInputSignature(value: unknown): string {
+  if (!value || typeof value !== 'object' || Array.isArray(value)) {
+    return normalizeCatalogName(String(value ?? ''));
+  }
+
+  const input = value as Record<string, unknown>;
+  const required =
+    input.required === false || input.optional === true || input.isRequired === false
+      ? 'optional'
+      : 'required';
+
+  return [
+    normalizeCatalogName(String(input.id ?? input.name ?? input.key ?? '')),
+    normalizeCatalogName(String(input.type ?? input.inputType ?? '')),
+    required,
+  ].join(':');
+}
+
+function shouldCheckTemplateFunctionality(result: TemplateAuditMarkdownResult): boolean {
+  return (
+    result.classification === 'live-run' &&
+    result.components.length > 0 &&
+    (result.runtimeInputs.length > 0 || result.requiredSecrets.length > 0)
+  );
+}
+
+function createTemplateFunctionalityKey(result: TemplateAuditMarkdownResult): string {
+  const category = normalizeCatalogName(result.category ?? '');
+  const classification = normalizeCatalogName(result.classification);
+  const components = [...result.components].sort().join(',');
+  const runtimeInputs = result.runtimeInputs.map(getRuntimeInputSignature).sort().join(',');
+  const requiredSecrets = result.requiredSecrets.map(normalizeCatalogName).sort().join(',');
+
+  return [category, classification, components, runtimeInputs, requiredSecrets].join('|');
+}
+
 export function summarizeTemplateCatalogQuality(
   results: TemplateAuditMarkdownResult[],
 ): TemplateCatalogQualitySummary {
   const byName = new Map<string, TemplateAuditMarkdownResult[]>();
+  const byFunctionality = new Map<string, TemplateAuditMarkdownResult[]>();
   for (const result of results) {
     const key = normalizeCatalogName(result.templateName);
-    if (!key) continue;
-    byName.set(key, [...(byName.get(key) ?? []), result]);
+    if (key) {
+      byName.set(key, [...(byName.get(key) ?? []), result]);
+    }
+
+    if (shouldCheckTemplateFunctionality(result)) {
+      const functionalityKey = createTemplateFunctionalityKey(result);
+      byFunctionality.set(functionalityKey, [
+        ...(byFunctionality.get(functionalityKey) ?? []),
+        result,
+      ]);
+    }
   }
 
   const duplicateNames = Array.from(byName.entries())
@@ -659,6 +711,13 @@ export function summarizeTemplateCatalogQuality(
       labels: group.map(getTemplateCatalogLabel),
     }));
 
+  const duplicateFunctionalities = Array.from(byFunctionality.entries())
+    .filter(([, group]) => group.length > 1)
+    .map(([key, group]) => ({
+      key,
+      labels: group.map(getTemplateCatalogLabel),
+    }));
+
   const lowValueCandidates = results
     .filter((result) => result.runtimeInputs.length === 0 && result.requiredSecrets.length === 0)
     .map((result) => ({
@@ -668,6 +727,7 @@ export function summarizeTemplateCatalogQuality(
 
   return {
     duplicateNames,
+    duplicateFunctionalities,
     lowValueCandidates,
   };
 }
@@ -682,6 +742,10 @@ export function getTemplateCatalogQualityFailures(
     failures.push(`Duplicate template name: ${group.labels.join(', ')}`);
   }
 
+  for (const group of summary.duplicateFunctionalities) {
+    failures.push(`Duplicate template functionality: ${group.labels.join(', ')}`);
+  }
+
   for (const candidate of summary.lowValueCandidates) {
     failures.push(`Low-value/static template: ${candidate.label} ${candidate.reason}`);
   }
@@ -696,6 +760,7 @@ export function renderTemplateCatalogQualityCheck(results: TemplateAuditMarkdown
     '# Template Catalog Quality Check',
     '',
     `Duplicate names: ${summary.duplicateNames.length}`,
+    `Duplicate functionality: ${summary.duplicateFunctionalities.length}`,
     `Low-value/static candidates: ${summary.lowValueCandidates.length}`,
   ];
 
@@ -767,6 +832,14 @@ export function renderTemplateAuditMarkdown({
     }
   }
 
+  if (catalogQuality.duplicateFunctionalities.length === 0) {
+    lines.push('- Duplicate functionality: none');
+  } else {
+    for (const group of catalogQuality.duplicateFunctionalities) {
+      lines.push(`- Duplicate functionality: ${group.labels.join(', ')}`);
+    }
+  }
+
   if (catalogQuality.lowValueCandidates.length === 0) {
     lines.push('- Low-value/static candidates: none');
   } else {