fix: resolve pre-existing TypeScript errors in worker and backend

Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>

Author: zebbern

backend/src/mcp-groups/mcp-groups.repository.ts

@@ -183,8 +183,9 @@ export class McpGroupsRepository {
 
     const result = await this.db.execute(query);
     const grouped = new Map<string, McpGroupServerRow[]>();
-    for (const row of result.rows as McpGroupServerRow[]) {
+    for (const row of result.rows as unknown as McpGroupServerRow[]) {
       const groupId = row.group_id;
+      if (!groupId) continue;
       if (!grouped.has(groupId)) {
         grouped.set(groupId, []);
       }
@@ -229,7 +230,7 @@ export class McpGroupsRepository {
     `;
 
     const result = await this.db.execute(query);
-    return result.rows as McpGroupServerRow[];
+    return result.rows as unknown as McpGroupServerRow[];
   }
 
   async addServerToGroup(

worker/src/temporal/activities/error-handler.ts

@@ -8,24 +8,14 @@
 
 import { ApplicationFailure } from '@temporalio/common';
 import { ValidationError } from '@shipsec/component-sdk';
-import type { INodeIOService } from '@shipsec/component-sdk';
+import type { INodeIOService, IScopedTraceService } from '@shipsec/component-sdk';
 import {
   truncateText,
   getErrorMessage,
   truncateDetails,
   ERROR_LOG_LIMIT,
 } from '../utils/string-helpers';
 
-interface TraceRecorder {
-  record(event: {
-    type: string;
-    timestamp: string;
-    message?: string;
-    error?: unknown;
-    level: string;
-  }): void;
-}
-
 interface ErrorHandlerContext {
   actionRef: string;
   componentId: string;
@@ -36,7 +26,7 @@ interface ErrorHandlerContext {
   joinStrategy?: unknown;
   triggeredBy?: string;
   failure?: unknown;
-  trace: TraceRecorder | undefined;
+  trace: IScopedTraceService | undefined;
   nodeIO: INodeIOService | undefined;
 }
 

worker/src/temporal/activities/input-validator.ts

@@ -10,19 +10,10 @@ import {
   ValidationError,
   type ComponentDefinition,
   type ComponentPortMetadata,
+  type IScopedTraceService,
 } from '@shipsec/component-sdk';
 import type { InputWarning } from './spill-resolver';
 
-interface TraceRecorder {
-  record(event: {
-    type: string;
-    timestamp: string;
-    message?: string;
-    level: string;
-    data?: unknown;
-  }): void;
-}
-
 /**
  * Validate that all required inputs are present and log trace warnings.
  *
@@ -32,7 +23,7 @@ export function validateRequiredInputs(
   warnings: InputWarning[],
   component: ComponentDefinition,
   resolvedParams: Record<string, unknown>,
-  trace: TraceRecorder | undefined,
+  trace: IScopedTraceService | undefined,
   actionRef: string,
 ): void {
   // Get input port metadata to check which inputs are truly required
@@ -69,7 +60,7 @@ export function validateRequiredInputs(
       timestamp: new Date().toISOString(),
       message: `Input '${warning.target}' mapped from ${warning.sourceRef}.${warning.sourceHandle} was undefined`,
       level: isRequired ? 'error' : 'warn',
-      data: warning,
+      data: warning as unknown as Record<string, unknown>,
     });
   }
 

worker/src/temporal/activities/run-component.activity.ts

@@ -314,7 +314,7 @@ export async function runComponentActivity(
 
     return { output, activeOutputPorts };
   } catch (error: unknown) {
-    await handleComponentError(error, {
+    return await handleComponentError(error, {
       actionRef: action.ref,
       componentId: action.componentId,
       activityId: activityInfo.activityId,