Skip to content

fix(component-sdk): remove raw pty diagnostics dump#10

Merged
zebbern merged 1 commit into
mainfrom
codex/quiet-docker-pty-diagnostics
Jun 20, 2026
Merged

fix(component-sdk): remove raw pty diagnostics dump#10
zebbern merged 1 commit into
mainfrom
codex/quiet-docker-pty-diagnostics

Conversation

@zebbern

@zebbern zebbern commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove the raw console.log('diag', diag) dump from the Docker PTY spawn fallback
  • keep the existing structured warning and standard-IO fallback behavior
  • add a regression test that mocks PTY spawn failure and verifies no raw diag console log is emitted

Verification

  • bun test packages/component-sdk/src/__tests__/runner-pty-diagnostics.test.ts
  • bun test packages/component-sdk
  • git diff --check
  • bun run typecheck
  • bun run lint
  • bun run test
  • git push -u origin codex/quiet-docker-pty-diagnostics pre-push hook

Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 20, 2026 16:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a noisy raw PTY diagnostics console.log from the component-sdk Docker runner’s PTY spawn fallback, while preserving structured warning logs and the standard-IO fallback behavior.

Changes:

  • Removed the raw console.log('diag', diag) dump when node-pty spawn fails.
  • Added a regression test that mocks PTY spawn failure and asserts the fallback path does not emit the raw diagnostics console log.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/component-sdk/src/runner.ts Removes the unstructured diagnostics console log from the PTY spawn failure fallback path.
packages/component-sdk/src/tests/runner-pty-diagnostics.test.ts Adds a regression test covering PTY spawn failure → standard-IO fallback, ensuring no raw diag console logging occurs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zebbern zebbern merged commit f5124bf into main Jun 20, 2026
6 checks passed
@zebbern zebbern deleted the codex/quiet-docker-pty-diagnostics branch June 20, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants