test(worker): gate test utility diagnostic logs#11
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces noise in worker tests by gating the createMockTrace() / createMockLogCollector() console mirroring behind an opt-in env var (SENTRIS_DEBUG_TESTS=1), while preserving the underlying event/log collection used for assertions.
Changes:
- Add
shouldMirrorTestDiagnostics()to conditionally mirrorTRACE:/LOG:output only whenSENTRIS_DEBUG_TESTS === '1'. - Keep trace/log collection behavior unchanged (events/logs are still recorded for tests to assert on).
- Add a regression test verifying default quiet behavior and explicit debug opt-in.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
worker/src/testing/test-utils.ts |
Gates diagnostic console.log mirroring behind SENTRIS_DEBUG_TESTS=1 without changing collected trace/log data. |
worker/src/testing/__tests__/test-utils.test.ts |
Adds coverage ensuring console mirroring is off by default and on when explicitly enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TRACE:/LOG:console mirroring behindSENTRIS_DEBUG_TESTS=1Verification
bun test worker/src/testing/__tests__/test-utils.test.tsfailed with 2 defaultconsole.logcallsbun test worker/src/testingbun test worker/src/components/it-automationgit diff --checkbun run lintbun run testbun run typecheckgit push -u origin codex/quiet-worker-test-utilspre-push hook