Skip to content

fix(worker): route mock agent diagnostics through logger #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zebbern merged 1 commit into from
Jun 20, 2026
Merged

fix(worker): route mock agent diagnostics through logger #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions worker/src/components/dev/__tests__/mock-agent.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,37 @@ describe('mock.agent', () => {
expect(result).toEqual({ discoveredTools: [], toolCount: 0, toolCallResults: [] });
});

test('writes diagnostics through the execution logger instead of console.log', async () => {
const component = componentRegistry.get('mock.agent');
expect(component).toBeDefined();

const consoleSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
const loggerInfo = vi.fn();

try {
await runComponentWithRunner(
component!.runner,
component!.execute,
{ inputs: {}, params: {} },
createTestContext({
logger: {
debug: () => {},
info: loggerInfo,
error: () => {},
warn: () => {},
},
}),
);

expect(consoleSpy).not.toHaveBeenCalled();
expect(loggerInfo).toHaveBeenCalledWith(
'[mock.agent] No connected tool nodes, returning empty list',
);
} finally {
consoleSpy.mockRestore();
}
});

test('discovers tools from gateway when connected tools exist', async () => {
const component = componentRegistry.get('mock.agent');
expect(component).toBeDefined();
Expand Down
31 changes: 17 additions & 14 deletions worker/src/components/dev/mock-agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,16 @@ const definition = defineComponent({

const callTools = params.callTools ?? true;
const maxToolCalls = params.maxToolCalls ?? 10;
const logDiagnostic = (message: string): void => {
context.logger.info(message);
};

const connectedIds = connectedToolNodeIds ?? [];
console.log(`[mock.agent] connectedToolNodeIds: ${connectedIds.join(', ') || '(none)'}`);
console.log(`[mock.agent] callTools=${callTools}, maxToolCalls=${maxToolCalls}`);
logDiagnostic(`[mock.agent] connectedToolNodeIds: ${connectedIds.join(', ') || '(none)'}`);
logDiagnostic(`[mock.agent] callTools=${callTools}, maxToolCalls=${maxToolCalls}`);

if (connectedIds.length === 0) {
console.log('[mock.agent] No connected tool nodes, returning empty list');
logDiagnostic('[mock.agent] No connected tool nodes, returning empty list');
return outputSchema.parse({ discoveredTools: [], toolCount: 0, toolCallResults: [] });
}

Expand All @@ -157,7 +160,7 @@ const definition = defineComponent({

// 2. Connect to gateway via MCP SDK client
const gatewayUrl = DEFAULT_GATEWAY_URL;
console.log(`[mock.agent] Connecting to gateway: ${gatewayUrl}`);
logDiagnostic(`[mock.agent] Connecting to gateway: ${gatewayUrl}`);

const transport = new TransportImpl(new URL(gatewayUrl), {
requestInit: {
Expand All @@ -183,9 +186,9 @@ const definition = defineComponent({
description: t.description,
}));

console.log(`[mock.agent] Discovered ${tools.length} tools:`);
logDiagnostic(`[mock.agent] Discovered ${tools.length} tools:`);
for (const tool of tools) {
console.log(` - ${tool.name}: ${tool.description ?? '(no description)'}`);
logDiagnostic(` - ${tool.name}: ${tool.description ?? '(no description)'}`);
}

// Phase 2: Call tools with test arguments
Expand All @@ -196,17 +199,17 @@ const definition = defineComponent({

for (const tool of tools) {
if (callCount >= maxToolCalls) {
console.log(`[mock.agent] Reached max tool calls (${maxToolCalls}), stopping.`);
logDiagnostic(`[mock.agent] Reached max tool calls (${maxToolCalls}), stopping.`);
break;
}

const testArgs = getTestArgsForTool(tool.name);
if (!testArgs) {
console.log(`[mock.agent] No test args for tool '${tool.name}', skipping call.`);
logDiagnostic(`[mock.agent] No test args for tool '${tool.name}', skipping call.`);
continue;
}

console.log(
logDiagnostic(
`[mock.agent] ▶ Calling tool '${tool.name}' with args: ${JSON.stringify(testArgs)}`,
);
const startTime = Date.now();
Expand All @@ -232,7 +235,7 @@ const definition = defineComponent({
}

if (isError) {
console.log(
logDiagnostic(
`[mock.agent] ✗ Tool '${tool.name}' returned error (${durationMs}ms): ${outputText.substring(0, 200)}`,
);
toolCallResults.push({
Expand All @@ -242,10 +245,10 @@ const definition = defineComponent({
error: outputText.substring(0, 500),
});
} else {
console.log(
logDiagnostic(
`[mock.agent] ✓ Tool '${tool.name}' succeeded (${durationMs}ms), output length: ${outputText.length} chars`,
);
console.log(
logDiagnostic(
`[mock.agent] Preview: ${outputText.substring(0, 200)}${outputText.length > 200 ? '...' : ''}`,
);
toolCallResults.push({
Expand All @@ -261,7 +264,7 @@ const definition = defineComponent({
} catch (error: unknown) {
const durationMs = Date.now() - startTime;
const errorMsg = error instanceof Error ? error.message : String(error);
console.log(
logDiagnostic(
`[mock.agent] ✗ Tool '${tool.name}' threw exception (${durationMs}ms): ${errorMsg}`,
);
toolCallResults.push({
Expand All @@ -277,7 +280,7 @@ const definition = defineComponent({

const succeeded = toolCallResults.filter((r) => r.success).length;
const failed = toolCallResults.filter((r) => !r.success).length;
console.log(
logDiagnostic(
`[mock.agent] Tool call summary: ${succeeded} succeeded, ${failed} failed out of ${toolCallResults.length} calls`,
);
}
Expand Down
Loading