Skip to content

fix(worker): gate mcp cleanup diagnostics#14

Merged
zebbern merged 1 commit into
mainfrom
codex/quiet-mcp-cleanup-diagnostics
Jun 20, 2026
Merged

fix(worker): gate mcp cleanup diagnostics#14
zebbern merged 1 commit into
mainfrom
codex/quiet-mcp-cleanup-diagnostics

Conversation

@zebbern

@zebbern zebbern commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • gate successful MCP cleanup status diagnostics behind workflowDiagnosticLog
  • keep warning/error output and explicit SKIP_CONTAINER_CLEANUP=true debug instructions unchanged
  • add a regression test covering default-quiet cleanup behavior

Verification

  • red test first: bun test worker/src/temporal/activities/__tests__/mcp.activity.test.ts failed with 3 console.log calls
  • bun test worker/src/temporal/activities/__tests__/mcp.activity.test.ts
  • bun test worker/src/temporal/activities
  • git diff --check
  • bun run lint
  • bun run typecheck
  • bun run test
  • bunx tsc --build worker --force && bun run typecheck after full test cleanup
  • git push -u origin codex/quiet-mcp-cleanup-diagnostics pre-push hook

Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 20, 2026 17:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces log noise from MCP cleanup by routing successful cleanup diagnostics through workflowDiagnosticLog (tied to SENTRIS_DEBUG_WORKFLOW), while keeping warning/error logs and the explicit SKIP_CONTAINER_CLEANUP=true debugging instructions unchanged.

Changes:

  • Replaced successful MCP cleanup console.log statements with workflowDiagnosticLog in cleanupRunResourcesActivity.
  • Added a regression test ensuring default behavior does not emit successful cleanup diagnostics to console.log.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
worker/src/temporal/activities/mcp.activity.ts Gates successful MCP cleanup diagnostics behind workflowDiagnosticLog while leaving warnings/errors and SKIP-cleanup instructions as-is.
worker/src/temporal/activities/__tests__/mcp.activity.test.ts Adds regression coverage verifying successful cleanup does not write to console.log by default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zebbern zebbern merged commit 066d9d8 into main Jun 20, 2026
6 checks passed
@zebbern zebbern deleted the codex/quiet-mcp-cleanup-diagnostics branch June 20, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants