fix(worker): gate mcp cleanup diagnostics#14
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces log noise from MCP cleanup by routing successful cleanup diagnostics through workflowDiagnosticLog (tied to SENTRIS_DEBUG_WORKFLOW), while keeping warning/error logs and the explicit SKIP_CONTAINER_CLEANUP=true debugging instructions unchanged.
Changes:
- Replaced successful MCP cleanup
console.logstatements withworkflowDiagnosticLogincleanupRunResourcesActivity. - Added a regression test ensuring default behavior does not emit successful cleanup diagnostics to
console.log.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
worker/src/temporal/activities/mcp.activity.ts |
Gates successful MCP cleanup diagnostics behind workflowDiagnosticLog while leaving warnings/errors and SKIP-cleanup instructions as-is. |
worker/src/temporal/activities/__tests__/mcp.activity.test.ts |
Adds regression coverage verifying successful cleanup does not write to console.log by default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflowDiagnosticLogSKIP_CONTAINER_CLEANUP=truedebug instructions unchangedVerification
bun test worker/src/temporal/activities/__tests__/mcp.activity.test.tsfailed with 3console.logcallsbun test worker/src/temporal/activities/__tests__/mcp.activity.test.tsbun test worker/src/temporal/activitiesgit diff --checkbun run lintbun run typecheckbun run testbunx tsc --build worker --force && bun run typecheckafter full test cleanupgit push -u origin codex/quiet-mcp-cleanup-diagnosticspre-push hook