fix(worker): gate human input activity diagnostics#18
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces noisy worker activity logging by routing successful Human Input activity diagnostics through the existing workflowDiagnosticLog gate (controlled by SENTRIS_DEBUG_WORKFLOW=1), while preserving console.warn for non-ideal paths. It also introduces targeted tests to ensure successful paths remain quiet by default.
Changes:
- Replaced
console.logusage in Human Input activities (create/cancel/expire) withworkflowDiagnosticLogto gate success diagnostics. - Added Bun tests asserting that successful create/cancel/expire paths do not emit
console.logoutput when workflow debugging is disabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| worker/src/temporal/activities/human-input.activity.ts | Gates success-path Human Input activity diagnostics behind workflowDiagnosticLog instead of unconditional console.log. |
| worker/src/temporal/activities/tests/human-input.activity.test.ts | Adds regression tests ensuring success-path diagnostics stay quiet by default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+77
to
+79
| initializeHumanInputActivity({ | ||
| database: database.db as unknown as NodePgDatabase<typeof schema>, | ||
| }); |
Comment on lines
+96
to
+98
| initializeHumanInputActivity({ | ||
| database: database.db as unknown as NodePgDatabase<typeof schema>, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification