fix(worker): gate mcp discovery cache diagnostics#19
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces noisy worker logs by routing MCP discovery cache “success” diagnostics through the existing workflowDiagnosticLog() gate (enabled via SENTRIS_DEBUG_WORKFLOW=1), while keeping the Redis cache format and TTL unchanged.
Changes:
- Replace unconditional
console.logon successful MCP discovery cache writes withworkflowDiagnosticLog(). - Add a regression test that proves successful cache writes do not call
console.logby default. - Keep the Redis key format and 5-minute TTL (
setex(..., 300, ...)) unchanged.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
worker/src/temporal/activities/mcp-discovery.activity.ts |
Gates the “cached discovery results” success log behind workflowDiagnosticLog() instead of always emitting to stdout. |
worker/src/temporal/activities/__tests__/mcp-discovery.activity.test.ts |
Adds a focused test with a mocked Redis client to ensure no default console.log output on successful cache writes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification