Skip to content

fix(worker): gate mcp discovery readiness diagnostics#20

Merged
zebbern merged 1 commit into
mainfrom
codex/quiet-mcp-discovery-readiness-logs
Jun 20, 2026
Merged

fix(worker): gate mcp discovery readiness diagnostics#20
zebbern merged 1 commit into
mainfrom
codex/quiet-mcp-discovery-readiness-logs

Conversation

@zebbern

@zebbern zebbern commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • route MCP discovery STDIO readiness progress diagnostics through workflowDiagnosticLog
  • expand MCP discovery diagnostics tests to cover cache writes and successful stdio readiness without console.log noise
  • keep warning/error paths and Docker cleanup behavior unchanged

Verification

  • bun test worker/src/temporal/activities/tests/mcp-discovery.activity.test.ts
  • bun test worker/src/temporal/activities
  • bun test worker
  • bun run typecheck
  • bun run lint
  • bun run test

Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 20, 2026 20:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces noisy MCP discovery progress output by routing successful STDIO readiness diagnostics through the existing workflowDiagnosticLog gate (controlled by SENTRIS_DEBUG_WORKFLOW), and extends the worker activity tests to verify both cache writes and that successful readiness does not emit console.log output by default.

Changes:

  • Replace console.log calls in waitForContainerReady with workflowDiagnosticLog to gate successful readiness/progress diagnostics.
  • Expand MCP discovery activity tests to cover Redis cache writes and to assert no default console.log noise on successful STDIO readiness/tool discovery.
  • Add module mocks in tests to safely exercise docker cleanup behavior without invoking real Docker.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
worker/src/temporal/activities/mcp-discovery.activity.ts Gates readiness/progress logs by switching to workflowDiagnosticLog in the container readiness polling loop.
worker/src/temporal/activities/__tests__/mcp-discovery.activity.test.ts Adds mocks + new assertions ensuring successful diagnostics stay silent by default and cache writes are exercised.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zebbern zebbern merged commit 83d6f8f into main Jun 20, 2026
6 checks passed
@zebbern zebbern deleted the codex/quiet-mcp-discovery-readiness-logs branch June 20, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants