fix(worker): gate mcp discovery readiness diagnostics#20
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces noisy MCP discovery progress output by routing successful STDIO readiness diagnostics through the existing workflowDiagnosticLog gate (controlled by SENTRIS_DEBUG_WORKFLOW), and extends the worker activity tests to verify both cache writes and that successful readiness does not emit console.log output by default.
Changes:
- Replace
console.logcalls inwaitForContainerReadywithworkflowDiagnosticLogto gate successful readiness/progress diagnostics. - Expand MCP discovery activity tests to cover Redis cache writes and to assert no default
console.lognoise on successful STDIO readiness/tool discovery. - Add module mocks in tests to safely exercise docker cleanup behavior without invoking real Docker.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
worker/src/temporal/activities/mcp-discovery.activity.ts |
Gates readiness/progress logs by switching to workflowDiagnosticLog in the container readiness polling loop. |
worker/src/temporal/activities/__tests__/mcp-discovery.activity.test.ts |
Adds mocks + new assertions ensuring successful diagnostics stay silent by default and cache writes are exercised. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification