fix(worker): gate mcp discovery collector diagnostics#21
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces noise from MCP discovery Docker/stdio-proxy diagnostics by routing info/debug-level collector logs through the workflow diagnostics gate, while keeping warn/error logs visible, and adds a regression test to ensure successful collector logs stay quiet by default.
Changes:
- Centralized MCP discovery log routing in
logMcpDiscoveryEntry()and gated info/debug logs viaworkflowDiagnosticLog. - Updated discovery container execution contexts to use the new log routing helper.
- Added a regression test asserting that docker info/debug collector logs do not hit the console by default.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| worker/src/temporal/activities/mcp-discovery.activity.ts | Routes MCP discovery collector info/debug logs through workflowDiagnosticLog while preserving warn/error visibility. |
| worker/src/temporal/activities/tests/mcp-discovery.activity.test.ts | Adds a focused regression test ensuring docker collector info/debug logs don’t mirror to console under default settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+203
to
+222
| const consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {}); | ||
| const consoleDebugSpy = vi.spyOn(console, 'debug').mockImplementation(() => {}); | ||
|
|
||
| try { | ||
| await discoverMcpGroupToolsActivity({ | ||
| servers: [ | ||
| { | ||
| name: 'storage', | ||
| transport: 'stdio', | ||
| command: 'storage-mcp', | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| expect(consoleLogSpy).not.toHaveBeenCalled(); | ||
| expect(consoleDebugSpy).not.toHaveBeenCalled(); | ||
| } finally { | ||
| consoleLogSpy.mockRestore(); | ||
| consoleDebugSpy.mockRestore(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification