fix(worker): gate script sandbox diagnostics#22
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces default noise from worker sandbox executions by gating “success-path” diagnostics behind environment flags, while keeping warnings/errors visible and adding regression tests to ensure quiet behavior by default.
Changes:
- Route webhook parsing sandbox collector logs so only warn/error hit the console by default; info/debug are gated behind
SENTRIS_DEBUG_WORKFLOW. - Gate Script/Logic sandbox diagnostics (HTTP loader + harness “start/completed/output written” logs) behind
SENTRIS_DEBUG_COMPONENTS, passing the flag into the container env. - Add/extend worker tests to assert diagnostics are quiet by default.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| worker/src/temporal/activities/webhook-parsing.activity.ts | Gates webhook parsing diagnostics via workflowDiagnosticLog and passes SENTRIS_DEBUG_WORKFLOW into the container. |
| worker/src/temporal/activities/tests/webhook-parsing.activity.test.ts | Adds regression test for quiet default behavior (but needs env/spies cleanup fixes). |
| worker/src/components/core/logic-script.ts | Gates Script/Logic sandbox success diagnostics behind SENTRIS_DEBUG_COMPONENTS and forwards flag into container env. |
| worker/src/components/core/tests/logic-script.test.ts | Adds coverage asserting debug gating is embedded into generated plugin/harness sources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+21
to
+25
| const originalDebugWorkflow = process.env.SENTRIS_DEBUG_WORKFLOW; | ||
|
|
||
| describe('executeWebhookParsingScriptActivity', () => { | ||
| beforeEach(() => { | ||
| delete process.env.SENTRIS_DEBUG_WORKFLOW; |
Comment on lines
+149
to
+155
| } finally { | ||
| if (originalDebugWorkflow === undefined) { | ||
| delete process.env.SENTRIS_DEBUG_WORKFLOW; | ||
| } else { | ||
| process.env.SENTRIS_DEBUG_WORKFLOW = originalDebugWorkflow; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification