Stabilize workflow parallelism test assertion#4
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the “workflow parallelism” unit test in the Temporal workflow runner by replacing fragile timer-duration lower-bound assertions with assertions that focus on scheduler behavior (branch overlap, merge ordering, and faster-than-serial runtime).
Changes:
- Replace per-branch elapsed-time lower-bound assertions with a branch-overlap assertion.
- Add an assertion that merge starts after both branches complete, and relax the total-runtime upper bound to reflect a serial baseline.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Math.max(branchA.startedAt, branchB.startedAt) < Math.min(branchA.endedAt, branchB.endedAt); | ||
| expect(branchesOverlap).toBe(true); | ||
|
|
||
| expect(merge.startedAt).toBeGreaterThanOrEqual(Math.max(branchA.endedAt, branchB.endedAt) - 5); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification