Skip to content

Stabilize workflow parallelism test assertion #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zebbern merged 1 commit into from
Jun 20, 2026
Merged

Stabilize workflow parallelism test assertion #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions worker/src/temporal/__tests__/workflow-runner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,13 +252,17 @@ describe('executeWorkflow', () => {
const branchStartDelta = Math.abs(branchA.startedAt - branchB.startedAt);
expect(branchStartDelta).toBeLessThan(75);

const branchAElapsed = branchA.endedAt - branchA.startedAt;
const branchBElapsed = branchB.endedAt - branchB.startedAt;
expect(branchAElapsed).toBeGreaterThanOrEqual(190);
expect(branchBElapsed).toBeGreaterThanOrEqual(190);
const branchesOverlap =
Math.max(branchA.startedAt, branchB.startedAt) < Math.min(branchA.endedAt, branchB.endedAt);
expect(branchesOverlap).toBe(true);

expect(merge.startedAt).toBeGreaterThanOrEqual(Math.max(branchA.endedAt, branchB.endedAt) - 5);

const totalElapsed = merge.endedAt - start.startedAt;
expect(totalElapsed).toBeLessThan(350);
// A serial execution would take roughly 450ms before merge overhead
// (50ms start + 200ms branchA + 200ms branchB). Keep the assertion about
// scheduler behavior, not timer precision.
expect(totalElapsed).toBeLessThan(450);
});

it('produces a deterministic trace sequence across repeated runs', async () => {
Expand Down
Loading