Parse frontend mock.module calls in test planner#6
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the frontend test planner’s “mock.module usage” detection to use a TypeScript AST traversal instead of raw text matching, so that only real mock.module(...) call expressions cause tests to be isolated (and quoted/commented text no longer triggers isolation).
Changes:
- Replace regex-based
mock.module(detection with a TypeScript ASTCallExpressioncheck formock.module(...). - Add a regression test ensuring
mock.moduleinside string literals and comments is ignored.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/test/run-tests-plan.ts | Switches usesMockModule() to parse the file with TypeScript and detect actual mock.module(...) calls via AST traversal. |
| frontend/src/test/run-tests-plan.test.ts | Adds a regression test covering commented/quoted mock.module text to prevent false-positive isolation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification