Skip to content

Propagate MCP server startup and tool timeouts from ACP metadata#285

Closed
stefandevo wants to merge 1 commit into
zed-industries:mainfrom
stefandevo:devflow/dev-3323-mcp-timeouts
Closed

Propagate MCP server startup and tool timeouts from ACP metadata#285
stefandevo wants to merge 1 commit into
zed-industries:mainfrom
stefandevo:devflow/dev-3323-mcp-timeouts

Conversation

@stefandevo

Copy link
Copy Markdown

Purpose

This PR lets ACP clients tune Codex MCP startup and tool-call timeouts for per-session MCP servers. This is useful for blocking MCP tools that wait on user interaction and can legitimately run longer than Codex's default tool timeout.

Key Changes

  • Reads startup_timeout_sec and tool_timeout_sec from each MCP server's _meta object.
  • Forwards those values into McpServerConfig for HTTP and stdio MCP servers.
  • Preserves existing behavior when timeout metadata is absent.
  • Adds unit coverage for absent metadata, explicit metadata, and ACP JSON metadata deserialization.
  • Documents the _meta timeout keys in both README files.

Checks

  • cargo test
  • cargo fmt --all -- --check
  • cargo clippy --all-targets --all-features -- -D warnings
  • bash npm/testing/validate.sh
  • node npm/testing/test-platform-detection.js

@benbrandt

Copy link
Copy Markdown
Member

Hi thanks for taking the time to dig in!
Development is moving to agentclientprotocol/codex-acp. The new adapter is built on the new Codex App Server, and we are pooling implementation and maintenance work across teams there. If this is still needed, please open a PR for that one. Thanks!

@benbrandt benbrandt closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants