Support generic ACP elicitation/create for structured input#295
Open
whats0Wong wants to merge 2 commits into
Open
Support generic ACP elicitation/create for structured input#295whats0Wong wants to merge 2 commits into
whats0Wong wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elicitation/createwhen the client advertises matching elicitation capabilities.session/request_permission.Op::ResolveElicitation, includingaction,content, and_meta.Notes
elicitation/createform/url forwarding path and capability-gated behavior. It does not send ACPelicitation/completenotifications yet, because the current Codex generic MCP elicitation event/Op flow exposed tocodex-acpprovidesElicitationRequest+ResolveElicitation, but not a separate URL out-of-band completion hook. Therefore URL-mode user consent is handled through theelicitation/createresponse, while a future upstream completion signal would be needed for a fully accurateelicitation/completebridge.Tests
cargo fmt --checkcargo testcargo clippy --all-targets -- -D warningsgit diff --checkCloses #294
Real validation with helix
Validated the generic form and url elicitation paths against
code.byted.org/devinfra/helixonorigin/feat/acp-elicitation-workerusing a real localcodex-acpprocess over ACP stdio and a real MCP stdio server.The validation confirmed the full create/resolve flow:
initializeadvertisesclientCapabilities.elicitation.formandclientCapabilities.elicitation.url,session/newandsession/promptsucceed, the MCP server issues genericelicitation/create,codex-acpforwards ACPelicitation/create, helix emitsWorkerSignalKindElicitationRequest, helixResolveElicitationreplies withaccept, and Codex completes the MCP tool call/end turn.This also exposed and this PR now fixes the real-event routing case where Codex emits MCP generic elicitation with event id
mcp_elicitation_requestinstead of the prompt submission id.