Add support for page up and page down in the picker#53152
Open
polyesterswing wants to merge 4 commits into
Open
Add support for page up and page down in the picker#53152polyesterswing wants to merge 4 commits into
polyesterswing wants to merge 4 commits into
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
guild
zed-codeowner-coordinator
Bot
requested review from
a team,
nathansobo and
osiewicz
and removed request for
a team
Contributor
SomeoneToIgnore
left a comment
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Thank you for working on this.
Given that we have added new actions for picker (select_prev_page and select_next_page), can we have a test for it?
Also mod tests is located really odd, if you could move it all the down, would be amazing.
|
Windows 11 - when I 'page up' or 'page down' in Keymap Editor, I go to the very top or the very bottom. |
Contributor
Author
|
@SomeoneToIgnore I've added tests now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38389
Release Notes: