-
-
Notifications
You must be signed in to change notification settings - Fork 733
Add new routes for embedding tweets and handling status requests #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cameronaaron
wants to merge
1
commit into
zedeus:master
Choose a base branch
from
cameronaaron:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,3 +13,4 @@ nitter.conf | |
| guest_accounts.json* | ||
| sessions.json* | ||
| dump.rdb | ||
| nitter.log | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,5 +77,56 @@ proc createStatusRouter*(cfg: Config) = | |
| get "/i/web/status/@id": | ||
| redirect("/i/status/" & @"id") | ||
|
|
||
| get "/i/status/@id/?": | ||
| let id = @"id" | ||
|
|
||
| if id.len > 19 or id.any(c => not c.isDigit): | ||
| resp Http404, showError("Invalid tweet ID", cfg) | ||
|
|
||
| let prefs = cookiePrefs() | ||
|
|
||
| # used for the infinite scroll feature | ||
| if @"scroll".len > 0: | ||
| let replies = await getReplies(id, getCursor()) | ||
| if replies.content.len == 0: | ||
| resp Http404, "" | ||
| resp $renderReplies(replies, prefs, getPath()) | ||
|
|
||
| let conv = await getTweet(id, getCursor()) | ||
| if conv == nil: | ||
| echo "nil conv" | ||
|
||
|
|
||
| if conv == nil or conv.tweet == nil or conv.tweet.id == 0: | ||
| var error = "Tweet not found" | ||
| if conv != nil and conv.tweet != nil and conv.tweet.tombstone.len > 0: | ||
| error = conv.tweet.tombstone | ||
| resp Http404, showError(error, cfg) | ||
|
|
||
| let | ||
| title = pageTitle(conv.tweet) | ||
| ogTitle = pageTitle(conv.tweet.user) | ||
| desc = conv.tweet.text | ||
|
|
||
| var | ||
| images = conv.tweet.photos | ||
| video = "" | ||
|
|
||
| if conv.tweet.video.isSome(): | ||
| images = @[get(conv.tweet.video).thumb] | ||
| video = getVideoEmbed(cfg, conv.tweet.id) | ||
| elif conv.tweet.gif.isSome(): | ||
| images = @[get(conv.tweet.gif).thumb] | ||
| video = getPicUrl(get(conv.tweet.gif).url) | ||
| elif conv.tweet.card.isSome(): | ||
| let card = conv.tweet.card.get() | ||
| if card.image.len > 0: | ||
| images = @[card.image] | ||
| elif card.video.isSome(): | ||
| images = @[card.video.get().thumb] | ||
|
|
||
| let html = renderConversation(conv, prefs, getPath() & "#m") | ||
| resp renderMain(html, request, cfg, prefs, title, desc, ogTitle, | ||
| images=images, video=video) | ||
|
|
||
| get "/@name/thread/@id/?": | ||
| redirect("/$1/status/$2" % [@"name", @"id"]) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The magic number 19 should be extracted to a named constant to clarify that this represents the maximum length of a tweet ID.