Video embeds#623
Closed
HookedBehemoth wants to merge 1 commit into
Closed
Conversation
Owner
|
Very interesting solution, thanks! Unfortunately it's not ready yet due to the issue mentioned here: #562 (comment) |
Contributor
Author
|
Digging through the proxy code, the actual data transfer code appears to already be chunked, no? |
Owner
|
Chunked yes, but special support for Twitter's mp4 quirks was necessary. Implementation here, testing would be greatly appreciated: #634 |
Contributor
Author
|
I gave up. Discord keeps breaking embeds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was made in response to TwitFix/fxtwitter shutting down.
It uses the twitter:player:* meta tags with mp4 video links.
The big downside right now is that descriptions won't be embedded on videos. TwitFix worked around this with yet another embed tag called oEmbed.
sample
