Skip to content

Commit c309e07

Browse files
committed
fix: use /tree/ instead of /blob/ for directory URLs
GitHub blob URLs pointing to directories get remapped to raw.githubusercontent.com by the link checker, which returns 400/404 for directories. Use /tree/ (the correct URL type for directories) instead. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
1 parent a0395c2 commit c309e07

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

cel-sampler/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ To use:
1111
* Follow the [instructions](https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/incubator/README.md#declarative-configuration) to configure OpenTelemetry with declarative configuration.
1212
* Configure the `.tracer_provider.sampler` to include the `cel_based` sampler.
1313

14-
Support is now available for the java agent, see an [example here](https://github.com/open-telemetry/opentelemetry-java-examples/blob/main/javaagent).
14+
Support is now available for the java agent, see an [example here](https://github.com/open-telemetry/opentelemetry-java-examples/tree/main/javaagent).
1515

1616
## Overview
1717

jmx-scraper/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ Like with the JMX Gatherer, the selection of provided metrics to use is still do
164164
However, there is now two distinct sets of metrics to select from using the `otel.jmx.target.source` configuration option:
165165

166166
- `legacy`: [metrics definitions](./src/main/resources) equivalent to JMX Gatherer definitions to help transition and preserve compatibility
167-
- `instrumentation`: [metrics definitions inherited from instrumentation](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/), which is now used as a reference for JMX metrics, those also aim to provide better alignment with [metrics semantic conventions](https://opentelemetry.io/docs/specs/semconv/general/metrics/).
167+
- `instrumentation`: [metrics definitions inherited from instrumentation](https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/), which is now used as a reference for JMX metrics, those also aim to provide better alignment with [metrics semantic conventions](https://opentelemetry.io/docs/specs/semconv/general/metrics/).
168168

169169
In both cases, the metrics definitions themselves are embedded in the JMX Scraper binary, thus they
170170
will only change if the release version of the JMX Scraper binary changes.

samplers/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ To use:
1313
* Follow the [instructions](https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/incubator/README.md#declarative-configuration) to configure OpenTelemetry with declarative configuration.
1414
* Configure the `.tracer_provider.sampler` to include the `rule_based_routing` sampler.
1515

16-
Support is now available for the java agent, see an [example here](https://github.com/open-telemetry/opentelemetry-java-examples/blob/main/javaagent).
16+
Support is now available for the java agent, see an [example here](https://github.com/open-telemetry/opentelemetry-java-examples/tree/main/javaagent).
1717

1818
Schema for `rule_based_routing` sampler:
1919

0 commit comments

Comments
 (0)