Merge pull request #65 from zeixcom/feature/ci-workflow

Feature/ci workflow

Author: estherbrunner

.github/workflows/ci.yml

@@ -0,0 +1,55 @@
+name: CI
+
+on:
+    push:
+        branches: [main, next]
+    pull_request:
+        branches: [main, next]
+
+jobs:
+    test:
+        runs-on: ubuntu-latest
+        steps:
+            - name: Checkout repository
+              uses: actions/checkout@v4
+
+            - name: Setup Bun
+              uses: oven-sh/setup-bun@v1
+              with:
+                  bun-version: latest
+
+            - name: Install dependencies
+              run: bun install --frozen-lockfile
+
+            - name: Typecheck
+              run: bunx tsc --noEmit
+
+            - name: Lint and format
+              run: bunx biome check .
+
+            - name: Unit tests
+              run: bun run test
+
+            - name: Bundle size regression
+              run: bun test test/regression-bundle.test.ts
+
+            - name: Build
+              run: bun run build
+
+    performance:
+        runs-on: ubuntu-latest
+        continue-on-error: true # informational only — shared runners are too noisy for timing assertions
+        steps:
+            - name: Checkout repository
+              uses: actions/checkout@v4
+
+            - name: Setup Bun
+              uses: oven-sh/setup-bun@v1
+              with:
+                  bun-version: latest
+
+            - name: Install dependencies
+              run: bun install --frozen-lockfile
+
+            - name: Performance regression (informational)
+              run: bun test test/regression-performance.test.ts

.github/workflows/npm-publish.yml

@@ -22,6 +22,9 @@ jobs:
             - name: Install all dependencies (including devDependencies for build)
               run: bun install
 
+            - name: Typecheck, lint, test, and bundle regression
+              run: bun run check
+
             - name: Build package
               run: bun run build
 

.zed/settings.json

@@ -4,22 +4,22 @@
 			"language_servers": ["!eslint", "..."],
 			"code_actions_on_format": {
 				"source.fixAll.biome": true,
-				"source.organizeImports.biome": true,
-			},
+				"source.organizeImports.biome": true
+			}
 		},
 		"JavaScript": {
 			"language_servers": ["!eslint", "..."],
 			"code_actions_on_format": {
 				"source.fixAll.biome": true,
-				"source.organizeImports.biome": true,
-			},
+				"source.organizeImports.biome": true
+			}
 		},
 		"TSX": {
 			"language_servers": ["!eslint", "..."],
 			"code_actions_on_format": {
 				"source.fixAll.biome": true,
-				"source.organizeImports.biome": true,
-			},
-		},
-	},
+				"source.organizeImports.biome": true
+			}
+		}
+	}
 }

bench/reactivity.bench.ts

@@ -648,8 +648,7 @@ group('Collection: chain 5 derivations (100 items)', () => {
 	bench('cause-effect', () => {
 		const list = createList(Array.from({ length: 100 }, (_, i) => i + 1))
 		let col = list.deriveCollection((v: number) => v * 2)
-		for (let i = 1; i < 5; i++)
-			col = col.deriveCollection((v: number) => v + 1)
+		for (let i = 1; i < 5; i++) col = col.deriveCollection((v: number) => v + 1)
 		col.get()
 	})
 })

biome.json

@@ -21,7 +21,9 @@
 	},
 	"javascript": {
 		"formatter": {
-			"quoteStyle": "double"
+			"quoteStyle": "single",
+			"semicolons": "asNeeded",
+			"arrowParentheses": "asNeeded"
 		}
 	},
 	"assist": {

package.json

@@ -38,6 +38,7 @@
 		"bench": "bun run bench/reactivity.bench.ts",
 		"test": "bun test --path-ignore-patterns=**/regression*",
 		"regression": "bun test test/regression-performance.test.ts && bun test test/regression-bundle.test.ts",
-		"lint": "bunx biome lint --write"
+		"check": "bunx tsc --noEmit && bunx biome check . && bun run test && bun test test/regression-bundle.test.ts",
+		"lint": "bunx biome check --write"
 	}
 }

src/errors.ts

@@ -173,10 +173,7 @@ class InvalidStoreMutationError extends TypeError {
 	 * @param prop - The property name that was directly mutated.
 	 * @param action - The kind of mutation attempted (`'assign to'`, `'delete'`, or `'define'`).
 	 */
-	constructor(
-		prop: string,
-		action: 'assign to' | 'delete' | 'define',
-	) {
+	constructor(prop: string, action: 'assign to' | 'delete' | 'define') {
 		const guidance =
 			action === 'delete'
 				? `use store.remove(${JSON.stringify(prop)})`

src/graph.ts

@@ -236,12 +236,7 @@ const deepEqualInner = (
 ): boolean => {
 	if (Object.is(a, b)) return true
 	if (typeof a !== typeof b) return false
-	if (
-		a == null ||
-		typeof a !== 'object' ||
-		b == null ||
-		typeof b !== 'object'
-	)
+	if (a == null || typeof a !== 'object' || b == null || typeof b !== 'object')
 		return false
 
 	// Cycle guard: if `a` is already on the current recursion path, treat this
@@ -406,8 +401,7 @@ function propagate(node: SinkNode, newFlag = FLAG_DIRTY): void {
 		}
 
 		// Propagate Check to sinks
-		for (let e = node.sinks; e; e = e.nextSink)
-			propagate(e.sink, FLAG_CHECK)
+		for (let e = node.sinks; e; e = e.nextSink) propagate(e.sink, FLAG_CHECK)
 	} else {
 		if ((flags & (FLAG_DIRTY | FLAG_CHECK)) >= newFlag) return
 
@@ -520,8 +514,7 @@ function recomputeTask(node: TaskNode<unknown & {}>): void {
 				if (node.error || !node.equals(next, node.value)) {
 					node.value = next
 					node.error = undefined
-					for (let e = node.sinks; e; e = e.nextSink)
-						propagate(e.sink)
+					for (let e = node.sinks; e; e = e.nextSink) propagate(e.sink)
 				}
 				setState(node.pendingNode, false)
 			})
@@ -539,8 +532,7 @@ function recomputeTask(node: TaskNode<unknown & {}>): void {
 				) {
 					// We don't clear old value on errors
 					node.error = error
-					for (let e = node.sinks; e; e = e.nextSink)
-						propagate(e.sink)
+					for (let e = node.sinks; e; e = e.nextSink) propagate(e.sink)
 				}
 				setState(node.pendingNode, false)
 			})
@@ -580,11 +572,7 @@ function refresh(node: SinkNode): void {
 
 	if (node.flags & FLAG_RUNNING) {
 		throw new CircularDependencyError(
-			'controller' in node
-				? TYPE_TASK
-				: 'value' in node
-					? TYPE_MEMO
-					: 'Effect',
+			'controller' in node ? TYPE_TASK : 'value' in node ? TYPE_MEMO : 'Effect',
 		)
 	}
 

src/nodes/collection.ts

@@ -61,9 +61,7 @@ type Collection<T extends {}, S extends Signal<T> = Signal<T>> = {
 	byKey(key: string): S | undefined
 	keyAt(index: number): string | undefined
 	indexOfKey(key: string): number
-	deriveCollection<R extends {}>(
-		callback: (sourceValue: T) => R,
-	): Collection<R>
+	deriveCollection<R extends {}>(callback: (sourceValue: T) => R): Collection<R>
 	deriveCollection<R extends {}>(
 		callback: (sourceValue: T, abort: AbortSignal) => Promise<R>,
 	): Collection<R>
@@ -154,10 +152,7 @@ function deriveCollection<T extends {}, U extends {}>(
 					const sourceValue = itemSignal.get() as U
 					if (sourceValue == null) return prev as T
 					return (
-						callback as (
-							sourceValue: U,
-							abort: AbortSignal,
-						) => Promise<T>
+						callback as (sourceValue: U, abort: AbortSignal) => Promise<T>
 					)(sourceValue, abort)
 				})
 			: createMemo(() => {

src/nodes/effect.ts

@@ -14,8 +14,8 @@ import {
 	registerCleanup,
 	runCleanup,
 	runEffect,
-	scheduleEffect,
 	type Signal,
+	scheduleEffect,
 	trimSources,
 } from '../graph'
 import { isTask } from './task'
@@ -32,9 +32,11 @@ type MaybePromise<T> = T | Promise<T>
  */
 type MatchHandlers<T extends readonly Signal<unknown & {}>[]> = {
 	/** Called when all signals have a value. Receives a tuple of resolved values. */
-	ok: (values: {
-		[K in keyof T]: T[K] extends Signal<infer V> ? V : never
-	}) => MaybePromise<MaybeCleanup>
+	ok: (
+		values: {
+			[K in keyof T]: T[K] extends Signal<infer V> ? V : never
+		},
+	) => MaybePromise<MaybeCleanup>
 	/** Called when one or more signals hold an error. Defaults to `console.error`. */
 	err?: (errors: readonly Error[]) => MaybePromise<MaybeCleanup>
 	/** Called when one or more signals are unset (pending). */
@@ -221,12 +223,14 @@ function match(
 		const owner = activeOwner
 		const controller = new AbortController()
 		registerCleanup(owner, () => controller.abort())
-		out.then(cleanup => {
-			if (!controller.signal.aborted && typeof cleanup === 'function')
-				registerCleanup(owner, cleanup)
-		}).catch(e => {
-			err([e instanceof Error ? e : new Error(String(e))])
-		})
+		out
+			.then(cleanup => {
+				if (!controller.signal.aborted && typeof cleanup === 'function')
+					registerCleanup(owner, cleanup)
+			})
+			.catch(e => {
+				err([e instanceof Error ? e : new Error(String(e))])
+			})
 	}
 }