-
Notifications
You must be signed in to change notification settings - Fork 6
feat: support Individual API Keys (issuer-less JWT) #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
conversun
wants to merge
10
commits into
zelentsov-dev:develop
Choose a base branch
from
conversun:feat/individual-api-key-support
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
98a6196
feat(model): make Company.issuerID optional to support Individual API…
conversun 392ad18
feat(jwt): emit sub:"user" for Individual Keys per Apple spec
conversun 91a9184
feat(config): allow omitting issuerID in env vars for Individual API …
conversun 5f31a4b
feat(ui): display API key type in company listing and startup log
conversun f23e04b
docs: document Individual API Key support
conversun 0e25059
ci: add release workflow that publishes binaries on tag push
conversun 62fbac7
ci: bump actions/checkout to v5 (Node 24)
conversun d0e589e
feat: ship launcher script as release asset for one-line install
conversun 235030f
chore: drop launcher script in favor of mise github backend
conversun 66d9c24
ci: build universal binary, publish darwin-arm64 and darwin-x86_64 as…
conversun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| name: Release | ||
|
|
||
| on: | ||
| push: | ||
| tags: ['v*'] | ||
|
|
||
| permissions: | ||
| contents: write | ||
|
|
||
| concurrency: | ||
| group: release-${{ github.ref }} | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| release: | ||
| name: Build & Publish Release | ||
| runs-on: macos-15 | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
|
|
||
| - name: Select Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_26.2.app | ||
|
|
||
| - name: Build universal binary (arm64 + x86_64) | ||
| run: swift build -c release --arch arm64 --arch x86_64 | ||
|
|
||
| - name: Package binaries | ||
| id: pkg | ||
| run: | | ||
| BIN_DIR=$(swift build -c release --arch arm64 --arch x86_64 --show-bin-path) | ||
| file "$BIN_DIR/asc-mcp" | ||
|
|
||
| mkdir -p stage && cp "$BIN_DIR/asc-mcp" stage/asc-mcp | ||
| ARM="asc-mcp-${GITHUB_REF_NAME}-darwin-arm64.tar.gz" | ||
| X64="asc-mcp-${GITHUB_REF_NAME}-darwin-x86_64.tar.gz" | ||
| tar -czf "$ARM" -C stage asc-mcp | ||
| cp "$ARM" "$X64" | ||
| shasum -a 256 "$ARM" > "${ARM}.sha256" | ||
| shasum -a 256 "$X64" > "${X64}.sha256" | ||
| echo "arm=$ARM" >> "$GITHUB_OUTPUT" | ||
| echo "x64=$X64" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Create GitHub Release | ||
| uses: softprops/action-gh-release@v2 | ||
| with: | ||
| generate_release_notes: true | ||
| files: | | ||
| ${{ steps.pkg.outputs.arm }} | ||
| ${{ steps.pkg.outputs.arm }}.sha256 | ||
| ${{ steps.pkg.outputs.x64 }} | ||
| ${{ steps.pkg.outputs.x64 }}.sha256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching all errors here and then returning makes
asc-mcp --testexit successfully even whentestAppMetadata()ortestCompanySwitching()fails. That regresses test-mode behavior from fail-fast to silent success, which can mask real breakages in local/CI smoke checks that rely on process exit status. Log the error if needed, but propagate it (or callexit(1)) so failed test runs are observable.Useful? React with 👍 / 👎.