chore: Refactor BitcoinExchange loadDataBase to handle bad input values and improve error handling

Author: zelhajou

module 09/ex00/BitcoinExchange.cpp

@@ -120,20 +120,19 @@ void BitcoinExchange::loadDataBase(const std::string &filename)
         if (!isValidDate(date))
             throw std::runtime_error("Error at line " + intToString(lineCount) + ": invalid date => " + date);
 
-        try
-        {
-            if (valueStr.find_first_not_of("0123456789.-") != std::string::npos)
-                throw std::runtime_error("Error at line " + intToString(lineCount) + ": invalid value => " + valueStr);                
-            float value = atof(valueStr.c_str());
-            
-            if (value < 0)
-                throw std::runtime_error("Error at line " + intToString(lineCount) + ": negative value => " + valueStr);
-            _database[date] = value;
-        }
-        catch (const std::exception &e)
-        {
+        std::stringstream ss2(valueStr);
+        float value;
+        ss2 >> value;
+
+        if (!ss2.eof())
             throw std::runtime_error("Error at line " + intToString(lineCount) + ": invalid value => " + valueStr);
-        }
+        
+      
+        if (value < 0)
+            throw std::runtime_error("Error at line " + intToString(lineCount) + ": negative value => " + valueStr);
+        
+        _database[date] = value;
+        
     }
     if (_database.empty())
         throw std::runtime_error("Error: empty database");

module 09/ex02/PmergeMe.cpp

@@ -241,9 +241,8 @@ void PmergeMe::sortDeque()
             int idx = insertionOrder[i];
             if (idx > 0 && idx < (int)pendChain.size())
             {
-                int elementToInsert = pendChain[idx];
-                std::deque<int>::iterator pos = std::lower_bound(result.begin(), result.end(), elementToInsert);
-                result.insert(pos, elementToInsert);
+                std::deque<int>::iterator pos = std::lower_bound(result.begin(), result.end(), pendChain[idx]);
+                result.insert(pos, pendChain[idx]);
             }
         }
     }
@@ -275,7 +274,7 @@ void PmergeMe::sort()
     // {
     //     if (_vec[i] < _vec[i - 1])
     //     {
-    //         std::cerr << "Error: std::vector is not sorted" << std::endl;
+    //         std::cerr << "Error: std::vector is no sorted" << std::endl;
     //         return;
     //     }
     // }