Upgrade standard to v17 to fix security vulnerabilities#52
Merged
Conversation
Resolves 3 Dependabot alerts: - fast-uri host confusion (GHSA-41) - fast-uri path traversal (GHSA-40) - lodash code injection via _.template (GHSA-38) The vulnerable packages came from eslint@7.x bundled in standard@16. standard@17 uses eslint@8.x which doesn't include these dependencies. Also auto-fixed object-shorthand lint warnings in connection_helper.js. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace Node 20 (EOL April 2026) with currently supported LTS versions - Fix matrix variable name bug (versions → node-version) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The simple_sentinel helper has a race condition where it sends kill -TERM to sentinel processes then immediately tries to rm -rf their directories. On faster systems or newer Node versions, the rm can fail because the process hasn't fully exited yet. Fix by gracefully shutting down Redis/Sentinel processes via redis-cli and waiting for them to actually exit before calling SentinelHelper.stop(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
zendesk-bartoszwasko
left a comment
zendesk-bartoszwasko
left a comment
There was a problem hiding this comment.
LGTM, with one comment.
zendesk-bartoszwasko
previously approved these changes
May 14, 2026
niall3rs
force-pushed
the
ncolfer/dependency-updates-may-2026
branch
from
4baf319 to
8b7ff0a
Compare
zendesk-bartoszwasko
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
standardfrom v16 to v17 to resolve 3 high-severity Dependabot alertsfast-uri,lodash) that came fromeslint@7.xconnection_helper.jsResolved Vulnerabilities
_.templateimports key namesTest plan
npm auditshows 0 vulnerabilitiesnpm run lintpasses🤖 Generated with Claude Code