Skip to content
This repository was archived by the owner on Apr 21, 2026. It is now read-only.

Log error output when a git command fails#4124

Merged
grosser merged 1 commit into
zendesk:masterfrom
envato:error-output
Jan 14, 2025
Merged

Log error output when a git command fails#4124
grosser merged 1 commit into
zendesk:masterfrom
envato:error-output

Conversation

@orien
Copy link
Copy Markdown
Contributor

@orien orien commented Jan 13, 2025

Following on from #3738. This time focusing on just the class that directs stderr to /dev/null: the GitRepository class.

@orien orien requested a review from grosser as a code owner January 13, 2025 05:03
Copy link
Copy Markdown
Contributor

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea/implementation,
I'm worried that this will hide stderr when executing a command via the UI though
(as in the err output will no longer show unless the command fails at the end, and it will only show at the end)
so for that case we should still interleave the stderr ?

@orien
Copy link
Copy Markdown
Contributor Author

orien commented Jan 14, 2025

I like the idea/implementation, I'm worried that this will hide stderr when executing a command via the UI though (as in the err output will no longer show unless the command fails at the end, and it will only show at the end) so for that case we should still interleave the stderr ?

That's very true. I will focus the proposal.

@orien orien force-pushed the error-output branch 2 times, most recently from 1c68eb1 to ba5d318 Compare January 14, 2025 11:32
@orien orien changed the title Return error output when git commands fail Log error output when a git command fails Jan 14, 2025
@orien orien force-pushed the error-output branch 2 times, most recently from d8da3a4 to 98a8a40 Compare January 14, 2025 11:54
@grosser
Copy link
Copy Markdown
Contributor

grosser commented Jan 14, 2025

super clean solution 🎉

@grosser grosser merged commit 26b3832 into zendesk:master Jan 14, 2025
@orien orien deleted the error-output branch January 14, 2025 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants