Merge pull request #354 from zendesk/minor-fix-messages

 fix: dedicated 404 error handling and improved error messages for connectors delete command

Author: saikambaiyyagari

packages/zcli-connectors/src/commands/connectors/delete.ts

@@ -85,6 +85,13 @@ export default class Delete extends Command {
       // Handle response
       if (response.status === 200 || response.status === 204) {
         this.log(chalk.green(`✓ Connector '${connectorName}' deleted successfully`))
+      } else if (response.status === 404) {
+        const errorMessage = `Connector '${connectorName}' not found. It may have already been deleted or does not exist.`
+        if (flags.verbose) {
+          this.logVerbose('\nError Details:', 'red')
+          this.logVerbose(errorMessage, 'red')
+        }
+        this.error(errorMessage, { exit: 1 })
       } else {
         // Handle error response
         spinner?.stop()

packages/zcli-connectors/tests/functional/delete.test.ts

@@ -320,7 +320,7 @@ describe('delete command', () => {
       })
     })
 
-    it('should handle 404 Not Found response', async () => {
+    it('should handle 404 Not Found response with specific not-found message', async () => {
       requestAPIStub.resolves({
         status: 404,
         data: { error: 'Not Found' }
@@ -335,11 +335,38 @@ describe('delete command', () => {
 
       sinon.assert.calledWith(
         errorStub,
-        sinon.match(/Failed to delete connector: HTTP 404/),
+        sinon.match(/Connector 'test-connector' not found\. It may have already been deleted or does not exist\./),
         sinon.match({ exit: 1 })
       )
     })
 
+    it('should log verbose error details on 404 when verbose flag is set', async () => {
+      parseStub.restore()
+      parseStub = sinon.stub(deleteCommand, 'parse' as any).resolves({
+        args: { connector: 'test-connector' },
+        flags: {
+          verbose: true,
+          force: true,
+          help: false
+        }
+      })
+
+      requestAPIStub.resolves({
+        status: 404,
+        data: { error: 'Not Found' }
+      })
+
+      try {
+        await deleteCommand.run()
+        expect.fail('Should have thrown an error')
+      } catch (error) {
+        // Expected
+      }
+
+      sinon.assert.calledWith(logStub, sinon.match(/Error Details:/))
+      sinon.assert.calledWith(logStub, sinon.match(/not found/))
+    })
+
     it('should handle 403 Forbidden response', async () => {
       requestAPIStub.resolves({
         status: 403,