fix: throw CLIError on write failures in rewriteAssets and rewriteTemplates

Align error handling with rewriteManifest instead of silently swallowing errors.

Author: luis-almeida

packages/zcli-themes/src/lib/rewriteAssets.test.ts

@@ -60,38 +60,27 @@ describe('rewriteAssets', () => {
     expect(writeFileSyncStub.callCount).to.equal(0)
   })
 
-  it('ignores write errors', () => {
+  it('throws an error when file cannot be written', () => {
     sinon.stub(fs, 'mkdirSync')
     const writeFileSyncStub = sinon.stub(fs, 'writeFileSync')
 
-    writeFileSyncStub.onFirstCall().throws(new Error('Permission denied'))
-    writeFileSyncStub.onSecondCall().returns(undefined)
+    writeFileSyncStub.throws(new Error('Permission denied'))
 
     const jsContent = Buffer.from('first').toString('base64')
-    const jsContent2 = Buffer.from('second').toString('base64')
 
     expect(() => {
-      rewriteAssets('theme/path', {
-        'a.js': jsContent,
-        'b.js': jsContent2
-      })
-    }).to.not.throw()
-
-    expect(writeFileSyncStub.callCount).to.equal(2)
+      rewriteAssets('theme/path', { 'a.js': jsContent })
+    }).to.throw('Failed to write asset file: theme/path/assets/a.js')
   })
 
-  it('ignores mkdir errors', () => {
-    const mkdirSyncStub = sinon.stub(fs, 'mkdirSync')
-    const writeFileSyncStub = sinon.stub(fs, 'writeFileSync')
-
-    mkdirSyncStub.throws(new Error('Permission denied'))
+  it('throws an error when assets directory cannot be created', () => {
+    sinon.stub(fs, 'mkdirSync').throws(new Error('Permission denied'))
+    sinon.stub(fs, 'writeFileSync')
 
     const jsContent = Buffer.from('hello').toString('base64')
 
     expect(() => {
       rewriteAssets('theme/path', { 'a.js': jsContent })
-    }).to.not.throw()
-
-    expect(writeFileSyncStub.callCount).to.equal(1)
+    }).to.throw('Failed to create assets directory: theme/path/assets')
   })
 })

packages/zcli-themes/src/lib/rewriteAssets.ts

@@ -1,12 +1,14 @@
+import { CLIError } from '@oclif/core/lib/errors'
 import * as fs from 'fs'
+import * as chalk from 'chalk'
 
 export default function rewriteAssets (themePath: string, assets: Record<string, string>) {
   const assetsDir = `${themePath}/assets`
 
   try {
     fs.mkdirSync(assetsDir, { recursive: true })
   } catch (error) {
-    // Ignore errors if directory can't be created
+    throw new CLIError(chalk.red(`Failed to create assets directory: ${assetsDir}`))
   }
 
   for (const [filename, base64Content] of Object.entries(assets)) {
@@ -15,7 +17,7 @@ export default function rewriteAssets (themePath: string, assets: Record<string,
     try {
       fs.writeFileSync(filePath, Buffer.from(base64Content, 'base64'))
     } catch (error) {
-      // Ignore errors if file can't be written
+      throw new CLIError(chalk.red(`Failed to write asset file: ${filePath}`))
     }
   }
 }

packages/zcli-themes/src/lib/rewriteTemplates.test.ts

@@ -34,22 +34,18 @@ describe('rewriteTemplates', () => {
     ])
   })
 
-  it('ignores write errors', () => {
+  it('throws an error when file cannot be written', () => {
     const writeFileSyncStub = sinon.stub(fs, 'writeFileSync')
 
-    writeFileSyncStub.onFirstCall().throws(new Error('Permission denied'))
-    writeFileSyncStub.onSecondCall().returns(undefined)
+    writeFileSyncStub.throws(new Error('Permission denied'))
 
     const templates = {
-      home_page: '<h1>Updated Home</h1>',
-      article_page: '<h1>Updated Article</h1>'
+      home_page: '<h1>Updated Home</h1>'
     }
 
     expect(() => {
       rewriteTemplates('theme/path', templates)
-    }).to.not.throw()
-
-    expect(writeFileSyncStub.callCount).to.equal(2)
+    }).to.throw('Failed to write template file: theme/path/templates/home_page.hbs')
   })
 
   it('handles empty templates object', () => {

packages/zcli-themes/src/lib/rewriteTemplates.ts

@@ -1,4 +1,6 @@
+import { CLIError } from '@oclif/core/lib/errors'
 import * as fs from 'fs'
+import * as chalk from 'chalk'
 
 export default function rewriteTemplates (themePath: string, templates: Record<string, string>) {
   for (const [identifier, content] of Object.entries(templates)) {
@@ -8,7 +10,7 @@ export default function rewriteTemplates (themePath: string, templates: Record<s
       try {
         fs.writeFileSync(filePath, content)
       } catch (error) {
-        // Ignore errors if file doesn't exist or can't be written
+        throw new CLIError(chalk.red(`Failed to write template file: ${filePath}`))
       }
     }
   }