Merge pull request #407 from ins0/fix/cleanup

Feature: Removed fluid interface from module entity/interface

Author: Ocramius

module/ZfModule/src/ZfModule/Entity/Module.php

@@ -56,13 +56,10 @@ public function getPhotoUrl()
 
     /**
      * @param string $photoUrl
-     * @return self
      */
     public function setPhotoUrl($photoUrl)
     {
         $this->photoUrl = $photoUrl;
-
-        return $this;
     }
 
     /**
@@ -75,13 +72,10 @@ public function getOwner()
 
     /**
      * @param string $owner
-     * @return self
      */
     public function setOwner($owner)
     {
         $this->owner = $owner;
-
-        return $this;
     }
 
     /**
@@ -94,13 +88,10 @@ public function getUpdatedAt()
 
     /**
      * @param string $updatedAt
-     * @return self
      */
     public function setUpdatedAt($updatedAt)
     {
         $this->updatedAt = $updatedAt;
-
-        return $this;
     }
 
     /**
@@ -121,13 +112,10 @@ public function getCreatedAtDateTime()
 
     /**
      * @param string $createdAt
-     * @return self
      */
     public function setCreatedAt($createdAt)
     {
         $this->createdAt = $createdAt;
-
-        return $this;
     }
 
     /**
@@ -140,13 +128,10 @@ public function getId()
 
     /**
      * @param int $id
-     * @return self
      */
     public function setId($id)
     {
         $this->id = (int) $id;
-
-        return $this;
     }
 
     /**
@@ -159,13 +144,10 @@ public function getUrl()
 
     /**
      * @param string $url
-     * @return self
      */
     public function setUrl($url)
     {
         $this->url = $url;
-
-        return $this;
     }
 
     /**
@@ -178,13 +160,10 @@ public function getDescription()
 
     /**
      * @param string $description
-     * @return self
      */
     public function setDescription($description)
     {
         $this->description = $description;
-
-        return $this;
     }
 
     /**
@@ -197,12 +176,9 @@ public function getName()
 
     /**
      * @param string $name
-     * @return self
      */
     public function setName($name)
     {
         $this->name = $name;
-
-        return $this;
     }
 }

module/ZfModule/src/ZfModule/Entity/ModuleInterface.php

@@ -6,12 +6,15 @@ interface ModuleInterface
 {
     /**
      * Get Owner
+     *
      * @return string
      */
     public function getOwner();
 
     /**
      * Set Owner
+     *
+     * @param string
      */
     public function setOwner($owner);
 
@@ -21,8 +24,11 @@ public function setOwner($owner);
      * @return string
      */
     public function getPhotoUrl();
+
     /**
      * Set Photo URL
+     *
+     * @param string
      */
     public function setPhotoUrl($photoUrl);
 
@@ -35,6 +41,7 @@ public function getUpdatedAt();
 
     /**
      * Set Updated at
+     *
      * @param int $updatedAt
      */
     public function setUpdatedAt($updatedAt);
@@ -64,7 +71,6 @@ public function getId();
      * Set id.
      *
      * @param int $id
-     * @return ModuleInterface
      */
     public function setId($id);
 
@@ -79,7 +85,6 @@ public function getUrl();
      * Set Url
      *
      * @param string $url
-     * @return ModuleInterface
      */
     public function setUrl($url);
 
@@ -94,7 +99,6 @@ public function getDescription();
      * Set Description
      *
      * @param string $description
-     * @return ModuleInterface
      */
     public function setDescription($description);
 
@@ -109,7 +113,6 @@ public function getName();
      * Set Name
      *
      * @param string $name
-     * @return ModuleInterface
      */
     public function setName($name);
 }

module/ZfModule/test/ZfModuleTest/Entity/ModuleTest.php

@@ -31,18 +31,6 @@ public function testDefaults()
         $this->assertNull($this->module->getUpdatedAt());
     }
 
-    public function testFluentInterface()
-    {
-        $this->assertSame($this->module, $this->module->setId(9000));
-        $this->assertSame($this->module, $this->module->setName('foo'));
-        $this->assertSame($this->module, $this->module->setDescription('bar'));
-        $this->assertSame($this->module, $this->module->setOwner('John Doe'));
-        $this->assertSame($this->module, $this->module->setPhotoUrl('http://www.example.com/photo.jpg'));
-        $this->assertSame($this->module, $this->module->setUrl('http://www.example.com'));
-        $this->assertSame($this->module, $this->module->setCreatedAt('2013-02-28 13:05:00'));
-        $this->assertSame($this->module, $this->module->setUpdatedAt('2013-02-28 13:05:00'));
-    }
-
     public function testSetOwner()
     {
         $owner = 'johndoe';