Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

[3.0] Mark static factories as deprecated#176

Open
boesing wants to merge 11 commits into
zendframework:developfrom
boesing:migration/zf3-deprecations
Open

[3.0] Mark static factories as deprecated#176
boesing wants to merge 11 commits into
zendframework:developfrom
boesing:migration/zf3-deprecations

Conversation

@boesing

@boesing boesing commented Sep 10, 2018

Copy link
Copy Markdown
Member

As requested in #175

… deprecated

- Piped `Zend\Cache\StorageFactory` logic to new `Zend\Cache\Storage\StorageFactory` which uses dependency injection instead of static methods
- Fixed unit tests for new PluginManager calls
- Trigger `E_USER_DEPRECATED` error on static factory calls
@boesing

boesing commented Sep 10, 2018

Copy link
Copy Markdown
Member Author

Need to add the new StorageFactory to the ServiceManager configuration. Reminder for myself.

@boesing

boesing commented Sep 11, 2018

Copy link
Copy Markdown
Member Author

Well, it looks like the pcntl_fork unit test for Filesystem fails in travis for PHP 7.2 lowest dependencies.
I am on PHP 7.2 locally and the unit tests wont fail. Any suggestions?

@Ocramius

Copy link
Copy Markdown
Member

Most likely unrelated to your changes

- Moved plugin attachment logic into the `AdapterPluginManager`
- Restored most of the old static `StorageFactory` with minor enhancements
- Removed unit tests for new `StorageFactory`
- Added unit test for extended options for `AdapterPluginManager`
@Ocramius Ocramius added this to the 2.9.0 milestone Sep 12, 2018
@boesing boesing changed the title [ZF3] Mark static factories as deprecated [3.0] Mark static factories as deprecated Nov 7, 2018
@michalbundyra michalbundyra modified the milestones: 2.9.0, 2.10.0 Aug 29, 2019
@weierophinney

Copy link
Copy Markdown
Member

This repository has been closed and moved to laminas/laminas-cache; a new issue has been opened at laminas/laminas-cache#3.

@weierophinney

Copy link
Copy Markdown
Member

This repository has been moved to laminas/laminas-cache. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-cache to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-cache.
  • In your clone of laminas/laminas-cache, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants