issue: rpc on update, 422 filtering error (#546)

* issue: rpc on update, 422 filtering error

the error appears to be caused by the json filtering logic, it is attempting
to utilize the filtering logic when there is an update on a list or json
field even if there are no such values to be filtered during an update
when attempting to set a new value

* fix: rpc update handling

* fix: undo the ORM side change since it's unrelated to the original issue

* fix: get back the `args ?? {}` safety guard

---------

Co-authored-by: ymc9 <104139426+ymc9@users.noreply.github.com>

Author: mwillbanks

packages/server/src/api/rpc/index.ts

@@ -221,14 +221,17 @@ export class RPCApiHandler<Schema extends SchemaDef = SchemaDef> implements ApiH
     }
 
     private async processRequestPayload(args: any) {
-        const { meta, ...rest } = args;
+        const { meta, ...rest } = args ?? {};
         if (meta?.serialization) {
             try {
                 // superjson deserialization
                 args = SuperJSON.deserialize({ json: rest, meta: meta.serialization });
             } catch (err) {
                 return { result: undefined, error: `failed to deserialize request payload: ${(err as Error).message}` };
             }
+        } else {
+            // drop meta when no serialization info is present
+            args = rest;
         }
         return { result: args, error: undefined };
     }

packages/server/test/api/rpc.test.ts

@@ -365,6 +365,7 @@ describe('RPC API Handler Tests', () => {
             float Float
             decimal Decimal
             boolean Boolean
+            stringList String[]
             bytes Bytes
             bars Bar[]
         }
@@ -386,6 +387,7 @@ describe('RPC API Handler Tests', () => {
         const dateValue = new Date();
         const bytesValue = new Uint8Array([1, 2, 3, 4]);
         const barBytesValue = new Uint8Array([7, 8, 9]);
+        const stringListValue = ['a', 'b', 'c'];
 
         const createData = {
             string: 'string',
@@ -396,6 +398,7 @@ describe('RPC API Handler Tests', () => {
             decimal: decimalValue,
             boolean: true,
             bytes: bytesValue,
+            stringList: stringListValue,
             bars: {
                 create: { bytes: barBytesValue },
             },
@@ -424,6 +427,8 @@ describe('RPC API Handler Tests', () => {
         expect(data.date instanceof Date).toBeTruthy();
         expect(Decimal.isDecimal(data.decimal)).toBeTruthy();
         expect(data.bars[0].bytes).toBeInstanceOf(Uint8Array);
+        expect(Array.isArray(data.stringList)).toBeTruthy();
+        expect(data.stringList).toEqual(stringListValue);
 
         // find with filter not found
         const serializedQ = SuperJSON.serialize({
@@ -506,6 +511,27 @@ describe('RPC API Handler Tests', () => {
         });
         expect(r.status).toBe(200);
         expect(r.data).toBeNull();
+
+        // validate update on stringList
+        const serializedUpdate = SuperJSON.serialize({
+            where: { id: 1 },
+            data: {
+                stringList: ['d', 'e', 'f'],
+            },
+        });
+        r = await handleRequest({
+            method: 'patch',
+            path: '/foo/update',
+            query: {},
+            client,
+            requestBody: {
+                ...(serializedUpdate.json as any),
+                meta: { serialization: serializedUpdate.meta },
+            },
+        });
+        expect(r.status).toBe(200);
+        expect(r.data).toBeTruthy();
+        expect(r.data.stringList).toEqual(['d', 'e', 'f']);
     });
 
     function makeHandler() {