Add murmurhash.

Author: sanny-io

packages/plugins/cache/package.json

@@ -44,8 +44,9 @@
     "dependencies": {
         "@zenstackhq/common-helpers": "workspace:*",
         "@zenstackhq/orm": "workspace:*",
-        "zod": "catalog:",
-        "json-stable-stringify": "^1.3.0"
+        "json-stable-stringify": "^1.3.0",
+        "murmurhash": "^2.0.1",
+        "zod": "catalog:"
     },
     "devDependencies": {
         "@zenstackhq/eslint-config": "workspace:*",

packages/plugins/cache/src/plugin.ts

@@ -1,5 +1,7 @@
+import { lowerCaseFirst } from '@zenstackhq/common-helpers';
 import { definePlugin } from '@zenstackhq/orm';
 import stableStringify from 'json-stable-stringify';
+import murmurhash from 'murmurhash';
 import { cacheEnvelopeSchema } from './schemas';
 import type { CacheEnvelope, CacheInvalidationOptions, CachePluginOptions } from './types';
 
@@ -27,25 +29,19 @@ export function defineCachePlugin(pluginOptions: CachePluginOptions) {
 
         onQuery: async ({ args, model, operation, proceed }) => {
             if (args && 'cache' in args) {
-                const argsWithoutCache: Record<string, unknown> = {};
+                const json = stableStringify({
+                    args,
+                    model,
+                    operation,
+                });
 
-                for (const [key, value] of Object.entries(args)) {
-                    if (key !== 'cache') {
-                        argsWithoutCache[key] = value;
-                    }
+                if (!json) {
+                    throw new Error(`Failed to serialize cache entry for ${lowerCaseFirst(model)}.${operation}`);
                 }
 
                 const cache = pluginOptions.provider;
                 const options = (args as CacheEnvelope).cache!;
-
-                // TODO: hash
-                const key = stableStringify({
-                    ...argsWithoutCache,
-                    options,
-                    model,
-                    operation,
-                })!;
-
+                const key = murmurhash.v3(json).toString();
                 const queryResultEntry = await cache.getQueryResult(key);
 
                 if (queryResultEntry) {

packages/plugins/cache/src/providers/memory.ts

@@ -17,7 +17,7 @@ export class MemoryCache implements CacheProvider {
     private checkExpiration() {
         for (const [key, entry] of this.queryResultStore.entries()) {
             if (entryIsExpired(entry)) {
-                this.delete(key);
+                this.queryResultStore.delete(key);
             }
         }
 
@@ -57,10 +57,6 @@ export class MemoryCache implements CacheProvider {
         return Promise.resolve();
     }
 
-    delete(key: string) {
-        return Promise.resolve(this.queryResultStore.delete(key));
-    }
-
     invalidate(options: CacheInvalidationOptions) {
         if (options.tags) {
             for (const tag of options.tags) {