This repository was archived by the owner on Mar 1, 2026. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 17
perf(orm): more aggressive caching of validation zod schemas #623
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4d221dd
WIP: more aggressive caching of validation zod schemas
ymc9 291833b
refactor: use a decorator-based approach for caching
ymc9 1a038be
update
ymc9 d0826ea
update
ymc9 51fb17c
update
ymc9 ec22acd
update
ymc9 d14e1ba
update
ymc9 4812270
remove object-type args from cache key
ymc9 c413572
update cache key
ymc9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import stableStringify from 'json-stable-stringify'; | ||
|
|
||
| /** | ||
| * Method decorator that caches the return value based on method name and arguments. | ||
| * | ||
| * Requirements: | ||
| * - Class must have a `getCache(key: string)` method | ||
| * - Class must have a `setCache(key: string, value: any)` method | ||
| */ | ||
| export function cache() { | ||
| return function (_target: any, propertyKey: string, descriptor: PropertyDescriptor) { | ||
| const originalMethod = descriptor.value; | ||
|
|
||
| descriptor.value = function ( | ||
| this: { | ||
| getCache: (key: string) => unknown; | ||
| setCache: (key: string, value: unknown) => void; | ||
| } & Record<string, unknown>, | ||
| ...args: any[] | ||
| ) { | ||
| // Build cache key object | ||
| const cacheKeyObj: Record<string, unknown> = { | ||
| $call: propertyKey, | ||
| $args: args.map((arg) => { | ||
| if (Array.isArray(arg)) { | ||
| // sort array arguments for consistent cache keys | ||
| return [...arg].sort(); | ||
| } else { | ||
| return arg; | ||
| } | ||
| }), | ||
| }; | ||
|
|
||
| // Generate stable string key | ||
| const cacheKey = stableStringify(cacheKeyObj)!; | ||
|
|
||
| // Check cache | ||
| const cached = this.getCache(cacheKey); | ||
| if (cached !== undefined) { | ||
| return cached; | ||
| } | ||
|
|
||
| // Execute original method | ||
| const result = originalMethod.apply(this, args); | ||
|
|
||
| // Store in cache | ||
| this.setCache(cacheKey, result); | ||
|
|
||
| return result; | ||
| }; | ||
|
|
||
| return descriptor; | ||
| }; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.