chore: clean up repo merging stale files

[ymc9]

No description provided.

[coderabbitai]

Important

Review skipped

Too many files!

This PR contains 256 files, which is 106 over the limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/clean-up-stale-files

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.

[claude]

Claude finished @ymc9's task —— View job

---

PR Review: Repository Cleanup

I've conducted a comprehensive review of this massive cleanup PR (161K+ deletions across 256 files). Here's my detailed analysis:

Review Tasks

• Analyze scope of deletions and understand what's being removed
• Check for remaining dependencies on deleted components
• Verify package.json consistency after cleanup
• Review CI/CD workflow impact
• Assess documentation and security implications
• Provide comprehensive feedback and recommendations

---

✅ What This PR Does Well

Architecture Simplification: This appears to be a major architectural refactoring moving from v2 to v3, which is a positive consolidation effort.

Dependency Cleanup: Removal of legacy packages and consolidation into a cleaner monorepo structure.

Maintained Core Functionality: The essential packages (CLI, ORM, Language, Schema, SDK, Server) have been preserved but likely reimplemented.

---

🚨 Critical Issues Requiring Immediate Attention

1. Missing PR Description

• Issue: No description provided explaining the scope and rationale
• Impact: Makes it impossible for reviewers to understand the intent
• Recommendation: Add comprehensive description explaining:
  • Migration from v2 to v3 architecture
  • Which features were deprecated vs reimplemented
  • Breaking changes for users
  • Migration guide for existing projects

2. Package Dependencies Analysis

The remaining packages appear to maintain references to the core architecture:

• ✅ @zenstackhq/schema - Reimplemented (much smaller scope)
• ✅ @zenstackhq/sdk - Reimplemented
• ✅ @zenstackhq/server - Reimplemented
• ✅ All workspace dependencies appear consistent

3. Workflow & CI Impact

Removed Workflows:

• integration-test.yml - ⚠️ Critical: Integration testing removed
• regression-test.yml - ⚠️ Critical: Regression testing removed
• Security workflows (security-*.yml) - ⚠️ High: Reduced security scanning
• Release automation removed

Recommendation: These removals significantly reduce CI coverage. Essential to verify that remaining build-test.yml covers the same scope.

---

🔍 Detailed Component Analysis

Major Packages Removed:

1. packages/runtime/ - Entire runtime package (27K+ lines)
2. packages/plugins/ - OpenAPI, SWR, TanStack Query, tRPC plugins
3. packages/ide/jetbrains/ - IntelliJ/JetBrains IDE support
4. packages/misc/redwood/ - RedwoodJS integration

Configuration Cleanup:

• Root-level ESLint, Jest configs removed
• .npmrc, .gitattributes removed
• Development container configs removed

Security Assessment:

• ✅ No sensitive data exposure in deletions
• ⚠️ Security workflows removed reduce scanning coverage
• ✅ Core security policy maintained

---

📋 Recommendations

High Priority:

1. Add detailed PR description explaining architectural changes
2. Restore integration/regression testing or prove equivalent coverage exists
3. Document migration path for users upgrading from v2 to v3
4. Test build pipeline to ensure no broken dependencies

Medium Priority:

1. Consider restoring security scanning workflows
2. Verify IDE support strategy (VSCode only now?)
3. Update main README to reflect new architecture
4. Consider keeping changelog for reference

Before Merge:

• Verify pnpm build succeeds
• Confirm pnpm test passes
• Test plugin system still works
• Validate CLI functionality intact

---

🎯 Overall Assessment

This appears to be a legitimate architectural refactoring from v2 to v3, not just arbitrary file deletion. The core functionality is preserved through reimplemented packages. However, the lack of documentation and testing coverage reduction are significant concerns.

Verdict: ⚠️ Conditional Approval - Address documentation and testing concerns before merge.

---