chore: more repo merge cleanup

[ymc9]

Summary by CodeRabbit

• Documentation

  • Updated README badge image reference and simplified the ZenStack V3 introduction text for improved clarity.

• Chores

  • Removed unused TypeScript configuration file from the schema package.

[claude]

Claude finished @ymc9's task —— View job

---

PR Review: chore: more repo merge cleanup

Reviewing changes for code quality, potential issues, performance, security, and test coverage.

Todo List:

• Analyze README.md changes
• Review deletion of tsconfig.vscode.json
• Check for any related files that might be affected
• Provide comprehensive feedback on all requested areas

Review Findings:

README.md Changes ✅

Changes Made:

• Line 12: Updated CI badge URL from zenstack-v3 to zenstack repository: /README.md:12
• Line 40: Removed reference to V2 repository link in "What's New in V3" section: /README.md:40

Assessment: Both changes are appropriate cleanup actions following a repository merge:

• The CI badge now correctly points to the current repository instead of the old zenstack-v3 repo
• Removing the V2 reference simplifies the documentation without losing important context about the rewrite

tsconfig.vscode.json Deletion ✅

File Removed: packages/schema/tsconfig.vscode.json
Content was:

{
    "extends": "../../tsconfig.base.json",
    "compilerOptions": {
        "outDir": "dist"
    },
    "include": ["src/**/*.ts"]
}

Impact Analysis:

• This was likely a VSCode-specific TypeScript configuration for the schema package
• The main packages/schema/tsconfig.json still exists and handles TypeScript compilation
• No other packages have similar tsconfig.vscode.json files, suggesting this was legacy/unused
• The deletion aligns with cleanup objectives and doesn't break functionality

Code Quality Assessment:

✅ Code Quality: Changes maintain consistency and improve accuracy
✅ Best Practices: Follows standard cleanup practices - removing unused files, updating outdated references
✅ Potential Bugs: No bugs introduced - changes are cosmetic and cleanup-focused
✅ Performance: No performance impact from these changes
✅ Security: No security implications - only documentation and config cleanup
✅ Test Coverage: No test changes needed - these are non-functional changes

Recommendation: APPROVE ✅

This PR successfully completes repository merge cleanup by:

1. Fixing outdated repository references in documentation
2. Removing an unused VSCode-specific TypeScript configuration

The changes are safe, appropriate, and align well with the PR's cleanup objective. No issues found.

---

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request updates documentation in README.md by refreshing the badge image URL and simplifying the V3 introduction text. Additionally, a TypeScript configuration file for VSCode in the schema package is removed, indicating a configuration cleanup.

Changes

Cohort / File(s)	Summary
Documentation Updates README.md	Badge image URL changed from zenstack-v3 to zenstack; V3 introduction sentence simplified by removing V2 reference.
Configuration Removal packages/schema/tsconfig.vscode.json	TypeScript configuration file deleted; affects VSCode schema package build configuration only.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A badge refreshed, an intro made lean,
Old configs swept from the build machine.
ZenStack gleams in its newest attire,
Tidy and clean—what more could we desire? ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is vague and generic, using 'more repo merge cleanup' which does not clearly convey what specific changes were made in the changeset.	Replace the vague title with a more specific description of the main changes, such as 'chore: update README badge and remove unused tsconfig' to better reflect the actual modifications.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/cleanup-1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@README.md`:
- Line 12: The badge image tag is missing an alt attribute which harms
accessibility; update the <img> element for the build status badge (the line
with
src="https://github.com/zenstackhq/zenstack/actions/workflows/build-test.yml/badge.svg")
to include a descriptive alt text (e.g., alt="Build status" or "CI build status
(build-test)"), ensuring the badge is accessible to screen readers.