Skip to content

Fix step-level if condition misplaced inside with block in claude-code-review workflow#2445

Merged
ymc9 merged 2 commits intochore/claude-review-cifrom
copilot/sub-pr-2444
Mar 4, 2026
Merged

Fix step-level if condition misplaced inside with block in claude-code-review workflow#2445
ymc9 merged 2 commits intochore/claude-review-cifrom
copilot/sub-pr-2444

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 4, 2026

if: was incorrectly nested inside the with: block with a stray extra space (19 vs 18), causing a YAML parse failure that prevented the workflow from executing at all.

Changes

  • Moved if: from inside with: to the correct step level (14-space indent)
  • Converted block scalar | syntax to inline ${{ }} expression appropriate for step conditions
# Before (broken: inside with: block, wrong indent)
              with:
                  ...
                   if: |
                      !contains(github.event.pull_request.title, '[WIP]')

# After (correct: step-level condition)
            - name: Run Claude Code Review
              if: ${{ !contains(github.event.pull_request.title, '[WIP]') }}
              uses: anthropics/claude-code-action@beta
              with:
                  ...

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…review.yml

Co-authored-by: ymc9 <104139426+ymc9@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on Claude code review Fix step-level if condition misplaced inside with block in claude-code-review workflow Mar 4, 2026
@ymc9 ymc9 marked this pull request as ready for review March 4, 2026 23:47
@ymc9 ymc9 merged commit 5d51f42 into chore/claude-review-ci Mar 4, 2026
2 checks passed
@ymc9 ymc9 deleted the copilot/sub-pr-2444 branch March 4, 2026 23:47
Copilot finished work on behalf of ymc9 March 4, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants