chore: zenstruck/foundry-behat a subpackage (#1084)

* refactor: src/Test/Behat as a subpackage

* chore(behat): make tests phpunit pass

* chore(behat): make phpstan & behat tests working

Author: nikophil

.gitattributes

@@ -19,6 +19,7 @@
 /phpunit-10.xml.dist            export-ignore
 /phpunit-paratest.xml.dist      export-ignore
 /psalm.xml                      export-ignore
+/src/Test/Behat                 export-ignore
 /stubs                          export-ignore
 /symfony.lock                   export-ignore
 /tests                          export-ignore

.github/workflows/bc-check.yml

@@ -22,16 +22,16 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Install dependencies
-        uses: ramsey/composer-install@v2
-        with:
-          composer-options: --prefer-dist
-
       - name: Install PHP with extensions.
         uses: shivammathur/setup-php@v2
         with:
           php-version: "8.5"
 
+      - name: Install dependencies
+        uses: ramsey/composer-install@v2
+        with:
+          composer-options: --prefer-dist
+
       - name: Install roave/backward-compatibility-check.
         run: composer bin bc-check require roave/backward-compatibility-check
 

.github/workflows/behat.yml

@@ -4,35 +4,31 @@ on:
   push:
     paths: &paths
       - .github/workflows/behat.yml
-      - bin/tools/behat
-      - src/Behat/**
-      - tests/Behat/**
-      - behat.yml
-      - composer.json
+      - src/Test/Behat/**
   pull_request:
     paths: *paths
   schedule:
     - cron: '0 0 1,16 * *'
 
+defaults:
+  run:
+    shell: bash
+    working-directory: ./src/Test/Behat
+
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
   cancel-in-progress: true
 
 jobs:
   behat:
-    name: P:${{ matrix.php }}, S:${{ matrix.symfony }}${{ matrix.deps == 'lowest' && ' (lowest)' || '' }}
+    name: Behat - P:${{ matrix.php }}, S:${{ matrix.symfony }}${{ matrix.deps == 'lowest' && ' (lowest)' || '' }}
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
         php: [ 8.3, 8.5 ]
         symfony: [ 6.4.*, 7.4.* ]
         deps: [ highest, lowest ]
-    env:
-      DATABASE_URL: 'sqlite:///%kernel.project_dir%/var/data.db'
-      USE_DAMA_DOCTRINE_TEST_BUNDLE: 1
-      USE_PHP_84_LAZY_OBJECTS: 1
-      MONGO_URL: ''
     steps:
       - name: Checkout code
         uses: actions/checkout@v3
@@ -51,16 +47,12 @@ jobs:
       - name: Install dependencies
         uses: ramsey/composer-install@v2
         with:
+          working-directory: "src/Test/Behat"
           dependency-versions: ${{ matrix.deps }}
           composer-options: --prefer-dist
         env:
           SYMFONY_REQUIRE: ${{ matrix.symfony }}
 
-      - name: Install Behat
-        run: composer bin behat update ${{ matrix.deps == 'lowest' && '--prefer-lowest' || '' }} --prefer-dist
-        env:
-          SYMFONY_REQUIRE: ${{ matrix.symfony }}
-
       - name: "Main test suite: reset DB at scenario level, with Dama support"
         run: vendor/bin/behat --colors -vvv
 
@@ -84,3 +76,67 @@ jobs:
 
       - name: Reset DB disabled
         run: vendor/bin/behat --colors -vvv --profile=reset-disabled
+
+  phpunit:
+    name: PHPUnit - P:${{ matrix.php }}, S:${{ matrix.symfony }}${{ matrix.deps == 'lowest' && ' (lowest)' || '' }}
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        php: [ 8.3, 8.5 ]
+        symfony: [ 6.4.*, 7.4.* ]
+        deps: [ highest, lowest ]
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          coverage: none
+          tools: flex
+
+      - name: Add the polyfill compatible with Doctrine ^2.16
+        if: ${{ matrix.deps == 'lowest' }}
+        run: composer require --dev symfony/polyfill-php80:^1.16 --no-update
+
+      - name: Install dependencies
+        uses: ramsey/composer-install@v2
+        with:
+          working-directory: "src/Test/Behat"
+          dependency-versions: ${{ matrix.deps }}
+          composer-options: --prefer-dist
+        env:
+          SYMFONY_REQUIRE: ${{ matrix.symfony }}
+
+      - name: Run tests
+        run: vendor/bin/phpunit
+
+  phpstan:
+    name: PhpStan
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.5
+          coverage: none
+          tools: flex
+
+      - name: Install dependencies
+        uses: ramsey/composer-install@v2
+        with:
+          working-directory: "src/Test/Behat"
+          composer-options: --prefer-dist
+        env:
+          SYMFONY_REQUIRE: 7.4.*
+
+      - name: Install PHPStan
+        run: composer bin phpstan install
+
+      - name: Run PHPStan
+        run: ../../../bin/tools/phpstan/vendor/phpstan/phpstan/phpstan

.github/workflows/static-analysis.yml

@@ -47,10 +47,8 @@ jobs:
       - name: Install PHPStan
         run: composer bin phpstan install
 
-      - name: Install PHPBench & Behat
-        run: |
-          composer bin phpbench install
-          composer bin behat install
+      - name: Install PHPBench
+        run: composer bin phpbench install
 
       - name: Run PHPStan
         run: bin/tools/phpstan/vendor/phpstan/phpstan/phpstan analyse

bin/console

@@ -6,13 +6,6 @@ use Zenstruck\Foundry\Tests\Fixture\TestKernel;
 
 require_once __DIR__ . '/../tests/bootstrap.php';
 
-foreach ($argv ?? [] as $i => $arg) {
-    if (($arg === '--env' || $arg === '-e') && isset($argv[$i + 1])) {
-        $_ENV['APP_ENV'] = $argv[$i + 1];
-        break;
-    }
-}
-
-$application = new Application(new TestKernel($_ENV['APP_ENV'], true));
+$application = new Application(new TestKernel('test', true));
 
 $application->run();

bin/tools/behat/.gitignore

@@ -23,7 +23,6 @@
         "symfony/polyfill-php85": "^1.33",
         "symfony/property-access": "^6.4|^7.0|^8.0",
         "symfony/property-info": "^6.4|^7.0|^8.0",
-        "symfony/string": "^6.4|^7.0|^8.0",
         "symfony/var-exporter": "^6.4.9|~7.0.9|^7.1.2|^8.0",
         "zenstruck/assert": "^1.4"
     },
@@ -47,7 +46,6 @@
         "symfony/framework-bundle": "^6.4|^7.0|^8.0",
         "symfony/maker-bundle": "^1.55",
         "symfony/phpunit-bridge": "^6.4.26|^7.0|^8.0",
-        "symfony/polyfill-php80": "^1.16",
         "symfony/routing": "^6.4|^7.0|^8.0",
         "symfony/runtime": "^6.4|^7.0|^8.0",
         "symfony/translation-contracts": "^3.4",
@@ -66,7 +64,8 @@
             "src/functions.php",
             "src/Persistence/functions.php",
             "src/symfony_console.php"
-        ]
+        ],
+        "exclude-from-classmap": ["src/Test/Behat/"]
     },
     "autoload-dev": {
         "psr-4": {
@@ -103,9 +102,6 @@
             "allow-contrib": false
         }
     },
-    "scripts": {
-        "post-install-cmd": ["@composer bin phpstan install", "@composer bin phpbench install", "@composer bin behat install"]
-    },
     "minimum-stability": "dev",
     "prefer-stable": true
 }