Commit 0365972
Zeph Gillen
Merge upstream v3.56.0 into local/daily-driver
Brings in:
- chore: prepare v3.56.0 release (Zoo-Code-Org#398)
- fix: API requests hang indefinitely on VS Code 1.122.0+ (Zoo-Code-Org#383)
- feat: add Claude Opus 4.8 support across Anthropic, Bedrock, and Vertex (Zoo-Code-Org#386)
- Show Zoo Code in outbound provider activity logs (Zoo-Code-Org#219)
Conflict resolutions and adjustments below.
Anthropic Opus 4.8 (packages/types/src/providers/anthropic.ts)
--------------------------------------------------------------
Kept our effort-array shape from 64fc5fc (supportsReasoningEffort:
[low, medium, high, xhigh, max], default "high", requiredReasoningEffort:
true). Discarded upstream's binary supportsReasoningBudget +
supportsReasoningBinary shape -- the local fork uses effort-based
reasoning across all Anthropic Opus 4.x models (foundation: fd93c5b).
Vertex Opus 4.8 (packages/types/src/providers/vertex.ts)
--------------------------------------------------------
Upstream's verbatim Vertex 4.8 entry would emit a 400 in our codebase:
unlike Bedrock, Vertex has no provider-side adaptive-thinking guard, so
the registry shape alone decides the request payload. With
supportsReasoningBudget: true, our getAnthropicReasoning() would emit
{ thinking: { type: "enabled", budget_tokens } } -- which Opus 4.8
rejects.
Converted Vertex 4.8 to the same effort-array shape as our Anthropic 4.8
so the helper hits the adaptive/effort branch and emits
{ thinking: { type: "adaptive" }, output_config: { effort: "high" } }.
The pre-existing Vertex Opus 4.7 entry still uses the legacy budget
shape (also broken on the API). That's a known follow-up from fd93c5b
and intentionally out of scope for this merge.
Vertex provider (src/api/providers/anthropic-vertex.ts)
-------------------------------------------------------
Dropped upstream's explicit getAnthropicProviderReasoning() call in
getModel() and the associated import. Our getModelParams({format:
"anthropic"}) already returns params.reasoning via the unified
getAnthropicReasoning helper (post-fd93c5bde), so the explicit call
would duplicate the wiring and lose user-chosen efforts (upstream's
call site omits reasoningEffort).
Bedrock (src/api/providers/bedrock.ts, packages/types/src/providers/bedrock.ts)
------------------------------------------------------------------------------
Took upstream verbatim. The Bedrock provider has its own
isAdaptiveThinkingModel guard that overrides the request payload
regardless of registry shape, so the budget-shape registry entries are
fine here.
Tests (src/api/providers/__tests__/anthropic.spec.ts)
-----------------------------------------------------
Rewrote four upstream-added Opus 4.8 tests that asserted the
budget/binary shape to mirror our existing 4.7 effort-shape tests:
- "should use adaptive thinking ..." -> assert output_config.effort: "high"
- "should omit thinking when reasoning disabled" -> replaced with
"should always emit adaptive thinking (reasoning is required)"
- "should preserve custom maxTokens" -> replaced with
"should honor user-chosen effort" (matching our 4.7 pattern)
- "should handle Claude Opus 4.8 model correctly" -> assert
supportsReasoningEffort array, default "high", requiredReasoningEffort
Verification
------------
- pnpm -w check-types: 11/11 packages clean
- pnpm -w test: 22 failures, all pre-existing in reasoning.spec.ts and
model-params.spec.ts (matches MEMORY baseline from fd93c5b fixture
drift). Zero new failures.81 files changed
Lines changed: 1674 additions & 765 deletions
File tree
- .changeset
- .roo/commands
- apps/vscode-e2e
- fixtures
- src
- suite/providers
- locales
- ca
- de
- es
- fr
- hi
- id
- it
- ja
- ko
- nl
- pl
- pt-BR
- ru
- tr
- vi
- zh-CN
- zh-TW
- packages
- cloud/src
- __tests__
- types/src/providers
- src
- api/providers
- __tests__
- utils
- core/webview
- integrations/openai-codex
- services/code-index
- embedders
- __tests__
- vector-store
- __tests__
- webview-ui/src/i18n/locales
- ca
- de
- en
- es
- fr
- hi
- id
- it
- ja
- ko
- nl
- pl
- pt-BR
- ru
- tr
- vi
- zh-CN
- zh-TW
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
| 56 | + | |
66 | 57 | | |
67 | 58 | | |
68 | 59 | | |
69 | 60 | | |
70 | 61 | | |
71 | 62 | | |
72 | | - | |
| 63 | + | |
73 | 64 | | |
74 | 65 | | |
75 | 66 | | |
76 | 67 | | |
77 | 68 | | |
78 | | - | |
| 69 | + | |
79 | 70 | | |
80 | 71 | | |
81 | 72 | | |
| |||
84 | 75 | | |
85 | 76 | | |
86 | 77 | | |
87 | | - | |
| 78 | + | |
88 | 79 | | |
89 | 80 | | |
90 | 81 | | |
91 | 82 | | |
92 | | - | |
| 83 | + | |
93 | 84 | | |
94 | 85 | | |
95 | | - | |
| 86 | + | |
96 | 87 | | |
97 | 88 | | |
98 | 89 | | |
99 | 90 | | |
100 | 91 | | |
101 | 92 | | |
102 | 93 | | |
103 | | - | |
| 94 | + | |
104 | 95 | | |
105 | 96 | | |
106 | 97 | | |
| |||
115 | 106 | | |
116 | 107 | | |
117 | 108 | | |
118 | | - | |
| 109 | + | |
119 | 110 | | |
120 | 111 | | |
121 | 112 | | |
| |||
124 | 115 | | |
125 | 116 | | |
126 | 117 | | |
127 | | - | |
| 118 | + | |
128 | 119 | | |
129 | 120 | | |
130 | 121 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
3 | 35 | | |
4 | 36 | | |
5 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
68 | 67 | | |
69 | 68 | | |
70 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
29 | 37 | | |
30 | 38 | | |
31 | 39 | | |
32 | 40 | | |
33 | 41 | | |
34 | 42 | | |
| 43 | + | |
35 | 44 | | |
36 | 45 | | |
37 | 46 | | |
| |||
49 | 58 | | |
50 | 59 | | |
51 | 60 | | |
52 | | - | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
53 | 64 | | |
54 | 65 | | |
55 | 66 | | |
| |||
0 commit comments