loader: remove unnecessary PINCTRL_DYNAMIC

PINCTRL_DYNAMIC is not used and increases memory footprint
unnecessarily. Remove it and the related gates in the code.

Signed-off-by: Luca Burelli <l.burelli@arduino.cc>

Author: pillo79

cores/arduino/zephyrCommon.cpp

@@ -9,7 +9,6 @@
 
 #include <zephyr/spinlock.h>
 
-#ifdef CONFIG_PINCTRL_DYNAMIC
 // create an array of arduino_pins with functions to reinitialize pins if needed
 static const struct device *pinmux_array[DT_PROP_LEN(DT_PATH(zephyr_user), digital_pin_gpios)] = {
 	nullptr};
@@ -22,7 +21,6 @@ void _reinit_peripheral_if_needed(pin_size_t pin, const struct device *dev) {
 		}
 	}
 }
-#endif
 
 static const struct gpio_dt_spec arduino_pins[] = {
 	DT_FOREACH_PROP_ELEM_SEP(
@@ -241,9 +239,7 @@ void yield(void) {
 void pinMode(pin_size_t pinNumber, PinMode pinMode) {
 	RETURN_ON_INVALID_PIN(pinNumber);
 
-#ifdef CONFIG_PINCTRL_DYNAMIC
 	_reinit_peripheral_if_needed(pinNumber, NULL);
-#endif
 	if (pinMode == INPUT) { // input mode
 		gpio_pin_configure_dt(&arduino_pins[pinNumber], GPIO_INPUT | GPIO_ACTIVE_HIGH);
 	} else if (pinMode == INPUT_PULLUP) { // input with internal pull-up
@@ -480,11 +476,8 @@ void analogWrite(pin_size_t pinNumber, int value) {
 		return;
 	}
 
-#ifdef CONFIG_PINCTRL_DYNAMIC
 	_reinit_peripheral_if_needed(pinNumber, arduino_pwm[idx].dev);
-#endif
 	value = CLAMP(value, 0, maxInput);
-	value = map(value, 0, 1 << _analog_write_resolution, 0, arduino_pwm[idx].period);
 
 	const uint32_t pulse = map64(value, 0, maxInput, 0, arduino_pwm[idx].period);
 
@@ -514,9 +507,7 @@ void analogWrite(enum dacPins dacName, int value) {
 
 		// TODO: add reverse map to find pin name from DAC* define
 		// In the meantime, consider A0 == DAC0
-#ifdef CONFIG_PINCTRL_DYNAMIC
 		_reinit_peripheral_if_needed((pin_size_t)(dacName + A0), dac_dev);
-#endif
 		ret = dac_channel_setup(dac_dev, &dac_ch_cfg[dacName]);
 		if (ret != 0) {
 			return;
@@ -579,9 +570,8 @@ int analogRead(pin_size_t pinNumber) {
 		return -ENOTSUP;
 	}
 
-#ifdef CONFIG_PINCTRL_DYNAMIC
 	_reinit_peripheral_if_needed(pinNumber, arduino_adc[idx].dev);
-#endif
+
 	err = adc_channel_setup(arduino_adc[idx].dev, &arduino_adc[idx].channel_cfg);
 	if (err < 0) {
 		return err;

cores/arduino/zephyrInternal.h

@@ -14,9 +14,7 @@ extern "C" {
 
 void enableInterrupt(pin_size_t);
 void disableInterrupt(pin_size_t);
-#ifdef CONFIG_PINCTRL_DYNAMIC
 void _reinit_peripheral_if_needed(pin_size_t pin, const struct device *dev);
-#endif
 
 #ifdef __cplusplus
 } // extern "C"

cores/arduino/zephyrSerial.cpp

@@ -58,9 +58,7 @@ void arduino::ZephyrSerial::begin(unsigned long baud, uint16_t conf) {
 		.flow_ctrl = UART_CFG_FLOW_CTRL_NONE,
 	};
 
-#ifdef CONFIG_PINCTRL_DYNAMIC
 	uart->ops.init(uart);
-#endif
 
 	uart_configure(uart, &config);
 	uart_irq_callback_user_data_set(uart, arduino::ZephyrSerial::IrqDispatch, this);

libraries/SPI/SPI.cpp

@@ -118,9 +118,7 @@ void arduino::ZephyrSPI::detachInterrupt() {
 }
 
 void arduino::ZephyrSPI::begin() {
-#ifdef CONFIG_PINCTRL_DYNAMIC
 	spi_dev->ops.init(spi_dev);
-#endif
 }
 
 void arduino::ZephyrSPI::end() {

libraries/Wire/Wire.cpp

@@ -15,9 +15,7 @@ arduino::ZephyrI2C::ZephyrI2C(const struct device *i2c) : i2c_dev(i2c) {
 
 void arduino::ZephyrI2C::begin() {
 	ring_buf_init(&rxRingBuffer.rb, sizeof(rxRingBuffer.buffer), rxRingBuffer.buffer);
-#ifdef CONFIG_PINCTRL_DYNAMIC
 	i2c_dev->ops.init(i2c_dev);
-#endif
 }
 
 void arduino::ZephyrI2C::begin(uint8_t slaveAddr) {